Bug 190326 - [Xcode] Don’t install yasm and don’t compile it in iOS device builds
Summary: [Xcode] Don’t install yasm and don’t compile it in iOS device builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-05 23:33 PDT by mitz
Modified: 2018-10-06 09:00 PDT (History)
5 users (show)

See Also:

Attachments
Skip install, and exclude all sources when building for a device (1.88 KB, patch)
2018-10-05 23:35 PDT, mitz 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2018-10-05 23:33:31 PDT 
yasm is used for building vpx for macOS and the iOS Simulator, but it doesn’t need to be installed, and it’s not used when building for iOS devices.

Patch forthcoming.
Comment 1 mitz 2018-10-05 23:35:18 PDT 
Created attachment 351718 [details]
Skip install, and exclude all sources when building for a device
Comment 2 youenn fablet 2018-10-06 07:14:45 PDT 
Comment on attachment 351718 [details]
Skip install, and exclude all sources when building for a device

Thanks!
Comment 3 WebKit Commit Bot 2018-10-06 07:41:43 PDT 
Comment on attachment 351718 [details]
Skip install, and exclude all sources when building for a device

Clearing flags on attachment: 351718

Committed r236896: <https://trac.webkit.org/changeset/236896>
Comment 4 WebKit Commit Bot 2018-10-06 07:41:44 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-10-06 07:42:26 PDT 
<rdar://problem/45068117>
Comment 6 mitz 2018-10-06 09:00:21 PDT 
(In reply to WebKit Commit Bot from comment #3)
> Comment on attachment 351718 [details]
> Skip install, and exclude all sources when building for a device
> 
> Clearing flags on attachment: 351718
> 
> Committed r236896: <https://trac.webkit.org/changeset/236896>

Fixed production builds for iOS devices in <https://trac.webkit.org/r236897>.