Bug 190319 – Make it more clear that a WebPageProxy always has an API::UIClient

• Status: NEW
• Component: New Bugs

[Alex Christensen]

Make it more clear that a WebPageProxy always has an API::UIClient

[Alex Christensen]

Created attachment 351686 [details]
Patch

[Alex Christensen]

Created attachment 351702 [details]
Patch

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Michael Catanzaro]

Comment on attachment 351702 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351702&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:-601
> -    if (!uiClient) {
> -        m_uiClient = std::make_unique<API::UIClient>();
> -        return;
> -    }

Yeah this wasn't great.

> Source/WebKit/UIProcess/WebPageProxy.h:1863
> -    std::unique_ptr<API::UIClient> m_uiClient;
> +    UniqueRef<API::UIClient> m_uiClient;

OK, so this is an opportunity for me to learn about UniqueRef. Looks like it's good when:

 * You need polymorphism, so a pointer or reference is required
 * You want ownership of a non-refcounted type
 * It's nonnull, so a reference is better than a pointer

I wonder why the standard library doesn't have this....