WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 190306
Web Inspector: notify the frontend when a canvas has started recording via console.record
https://bugs.webkit.org/show_bug.cgi?id=190306
Summary
Web Inspector: notify the frontend when a canvas has started recording via co...
Devin Rousso
Reported
2018-10-04 23:10:28 PDT
This would prevent the unexpected state where `console.record` is called and then the frontend later requests a recording, resulting in an error.
Attachments
Patch
(11.58 KB, patch)
2018-10-05 01:23 PDT
,
Devin Rousso
no flags
Details
Formatted Diff
Diff
Patch
(11.57 KB, patch)
2018-10-05 01:29 PDT
,
Devin Rousso
no flags
Details
Formatted Diff
Diff
Patch
(13.78 KB, patch)
2018-10-08 20:03 PDT
,
Devin Rousso
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews117 for mac-sierra
(3.08 MB, application/zip)
2018-10-08 22:04 PDT
,
EWS Watchlist
no flags
Details
Patch
(20.16 KB, patch)
2018-10-08 22:53 PDT
,
Devin Rousso
no flags
Details
Formatted Diff
Diff
Show Obsolete
(4)
View All
Add attachment
proposed patch, testcase, etc.
Devin Rousso
Comment 1
2018-10-05 01:23:42 PDT
Created
attachment 351663
[details]
Patch
Devin Rousso
Comment 2
2018-10-05 01:29:57 PDT
Created
attachment 351664
[details]
Patch
Blaze Burg
Comment 3
2018-10-08 09:36:07 PDT
Comment on
attachment 351664
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=351664&action=review
This change looks fine (excepting that it doesn't apply to TOT). Please rebase.
> Source/JavaScriptCore/inspector/protocol/Canvas.json:197 > + { "name": "fromConsole", "type": "boolean" }
I'd prefer that this be "initiator" with enum { Frontend, ConsoleAPI }. Thinking ahead to the various ways console logs can be initiated, this seems more future-proof if we add other means to trigger this. I also just generically don't like adding boolean flags to the protocol.
Devin Rousso
Comment 4
2018-10-08 10:02:20 PDT
Comment on
attachment 351664
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=351664&action=review
(In reply to Brian Burg from
comment #3
)
> This change looks fine (excepting that it doesn't apply to TOT). Please > rebase.
It won't apply because it needs changes made in <
https://webkit.org/b/190305
> (which is blocking this one).
>> Source/JavaScriptCore/inspector/protocol/Canvas.json:197 >> + { "name": "fromConsole", "type": "boolean" } > > I'd prefer that this be "initiator" with enum { Frontend, ConsoleAPI }. Thinking ahead to the various ways console logs can be initiated, this seems more future-proof if we add other means to trigger this. I also just generically don't like adding boolean flags to the protocol.
Oooo I like it!
Devin Rousso
Comment 5
2018-10-08 20:03:51 PDT
Created
attachment 351849
[details]
Patch
EWS Watchlist
Comment 6
2018-10-08 22:04:56 PDT
Comment hidden (obsolete)
Comment on
attachment 351849
[details]
Patch
Attachment 351849
[details]
did not pass mac-debug-ews (mac): Output:
https://webkit-queues.webkit.org/results/9499071
New failing tests: inspector/canvas/recording-bitmaprenderer.html
EWS Watchlist
Comment 7
2018-10-08 22:04:57 PDT
Comment hidden (obsolete)
Created
attachment 351857
[details]
Archive of layout-test-results from ews117 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-sierra Platform: Mac OS X 10.12.6
Devin Rousso
Comment 8
2018-10-08 22:53:05 PDT
Created
attachment 351860
[details]
Patch
Blaze Burg
Comment 9
2018-10-10 11:02:27 PDT
Comment on
attachment 351860
[details]
Patch r=me
WebKit Commit Bot
Comment 10
2018-10-10 11:34:56 PDT
Comment on
attachment 351860
[details]
Patch Clearing flags on attachment: 351860 Committed
r237010
: <
https://trac.webkit.org/changeset/237010
>
WebKit Commit Bot
Comment 11
2018-10-10 11:34:58 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 12
2018-10-10 11:35:24 PDT
<
rdar://problem/45167312
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug