Bug 190300 - [WPE][JSC] Use Unified Sources for Platform-specific sources
Summary: [WPE][JSC] Use Unified Sources for Platform-specific sources
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-04 18:23 PDT by Carlos Bentzen
Modified: 2018-10-05 08:11 PDT (History)
9 users (show)

See Also:


Attachments
Patch (5.75 KB, patch)
2018-10-04 18:44 PDT, Carlos Bentzen
no flags Details | Formatted Diff | Diff
Patch (5.75 KB, patch)
2018-10-04 18:48 PDT, Carlos Bentzen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Bentzen 2018-10-04 18:23:39 PDT
Currently the source files for the Remote Inspector in WPE are not integrated in Unified Sources, while the same sources for WebKitGTK+ are.
Comment 1 Carlos Bentzen 2018-10-04 18:44:57 PDT
Created attachment 351646 [details]
Patch
Comment 2 Carlos Bentzen 2018-10-04 18:48:22 PDT
Created attachment 351647 [details]
Patch
Comment 3 Adrian Perez 2018-10-05 07:34:44 PDT
Comment on attachment 351647 [details]
Patch

Patch LGTM. We'll need a reviewer to set the r+, tho.

Something that I am not particularly happy about is in general the unified
sources mechanism (so this is nothing about your patch in particular, so
no worries) because the way it works it basically breaks a lot of tooling:
using YCM, code indexers, clangd/ccls, and many more “sees” the unified
sources when what the tooling really needs to see is the original sources.
But the build speed improvement is too good to let it go... ¬_¬
Comment 4 Yusuke Suzuki 2018-10-05 07:40:50 PDT
Comment on attachment 351647 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2018-10-05 08:06:30 PDT
Comment on attachment 351647 [details]
Patch

Clearing flags on attachment: 351647

Committed r236873: <https://trac.webkit.org/changeset/236873>
Comment 6 WebKit Commit Bot 2018-10-05 08:06:32 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Adrian Perez 2018-10-05 08:11:11 PDT
Thanks Yusuke for stopping by and checking the patch 🙌