Bug 190298 - Web Inspector: REGRESSION (r236766): Storage tab no longer updates after main frame navigation
Summary: Web Inspector: REGRESSION (r236766): Storage tab no longer updates after main...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-04 16:35 PDT by Matt Baker
Modified: 2018-10-04 21:04 PDT (History)
4 users (show)

See Also:

Attachments
Patch (8.04 KB, patch)
2018-10-04 16:38 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2018-10-04 16:35:46 PDT 
Summary:
Storage tab no longer updates after main frame navigation.

Steps to Reproduce:
1. Inspect any page with cookies
2. Open Storage tab
3. Reload inspected page
  => Storage tab content view and navigation sidebar are empty

This regressed in https://trac.webkit.org/changeset/236766.

Note:
Prior to the patch that caused the regression, StorageSidebarPanel only listened for StorageManager.Event.Cleared (now DOMStorageManager). Cleared events from other managers were ignored. A main frame navigation causes all these managers to now broadcast Cleared events, which are interleaved with events for their respective storage objects being added. This causes the content tree in the Storage sidebar panel to get thrashed during frame navigation.
Comment 1 Matt Baker 2018-10-04 16:38:17 PDT 
Created attachment 351641 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2018-10-04 16:38:54 PDT 
<rdar://problem/45026857>
Comment 3 Joseph Pecoraro 2018-10-04 20:37:52 PDT 
Comment on attachment 351641 [details]
Patch

r=me, thanks for fixing this up!
Comment 4 WebKit Commit Bot 2018-10-04 21:04:18 PDT 
Comment on attachment 351641 [details]
Patch

Clearing flags on attachment: 351641

Committed r236868: <https://trac.webkit.org/changeset/236868>
Comment 5 WebKit Commit Bot 2018-10-04 21:04:19 PDT 
All reviewed patches have been landed.  Closing bug.