RESOLVED FIXED 190298
Web Inspector: REGRESSION (r236766): Storage tab no longer updates after main frame navigation 
https://bugs.webkit.org/show_bug.cgi?id=190298
Summary Web Inspector: REGRESSION (r236766): Storage tab no longer updates after main...
Matt Baker
Reported 2018-10-04 16:35:46 PDT
Summary: Storage tab no longer updates after main frame navigation. Steps to Reproduce: 1. Inspect any page with cookies 2. Open Storage tab 3. Reload inspected page => Storage tab content view and navigation sidebar are empty This regressed in https://trac.webkit.org/changeset/236766. Note: Prior to the patch that caused the regression, StorageSidebarPanel only listened for StorageManager.Event.Cleared (now DOMStorageManager). Cleared events from other managers were ignored. A main frame navigation causes all these managers to now broadcast Cleared events, which are interleaved with events for their respective storage objects being added. This causes the content tree in the Storage sidebar panel to get thrashed during frame navigation.
Attachments
Patch (8.04 KB, patch)
2018-10-04 16:38 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Matt Baker
Comment 1 2018-10-04 16:38:17 PDT
Created attachment 351641 [details] Patch
Radar WebKit Bug Importer
Comment 2 2018-10-04 16:38:54 PDT
<rdar://problem/45026857>
Joseph Pecoraro
Comment 3 2018-10-04 20:37:52 PDT
Comment on attachment 351641 [details] Patch r=me, thanks for fixing this up!
WebKit Commit Bot
Comment 4 2018-10-04 21:04:18 PDT
Comment on attachment 351641 [details] Patch Clearing flags on attachment: 351641 Committed r236868: <https://trac.webkit.org/changeset/236868>
WebKit Commit Bot
Comment 5 2018-10-04 21:04:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.