Bug 190283 - Disable Options::useWebAssemblyFastMemory() on linux if ASAN signal handling is not disabled.
Summary: Disable Options::useWebAssemblyFastMemory() on linux if ASAN signal handling ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-04 11:20 PDT by Mark Lam
Modified: 2018-10-04 12:24 PDT (History)
7 users (show)

See Also:

Attachments
proposed patch. (2.75 KB, patch)
2018-10-04 11:30 PDT, Mark Lam 		keith_miller: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2018-10-04 11:20:33 PDT 
Will also print a warning if we detect this condition.
Comment 1 Radar WebKit Bug Importer 2018-10-04 11:28:05 PDT 
<rdar://problem/45015752>
Comment 2 Mark Lam 2018-10-04 11:30:55 PDT 
Created attachment 351607 [details]
proposed patch.
Comment 3 Keith Miller 2018-10-04 12:14:58 PDT 
Comment on attachment 351607 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=351607&action=review

r=me with comment.

> Source/JavaScriptCore/runtime/Options.cpp:581
> +                    && (strstr(asanOptions, "allow_user_segv_handler=1") || strstr(asanOptions, "handle_segv=0"));

Do we actually need both or does ASAN work with just allow_user_segv_handler=1?
Comment 4 Mark Lam 2018-10-04 12:17:40 PDT 
Comment on attachment 351607 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=351607&action=review

>> Source/JavaScriptCore/runtime/Options.cpp:581
>> +                    && (strstr(asanOptions, "allow_user_segv_handler=1") || strstr(asanOptions, "handle_segv=0"));
> 
> Do we actually need both or does ASAN work with just allow_user_segv_handler=1?

We're checking for either here.
Comment 5 Keith Miller 2018-10-04 12:22:21 PDT 
Comment on attachment 351607 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=351607&action=review

>>> Source/JavaScriptCore/runtime/Options.cpp:581
>>> +                    && (strstr(asanOptions, "allow_user_segv_handler=1") || strstr(asanOptions, "handle_segv=0"));
>> 
>> Do we actually need both or does ASAN work with just allow_user_segv_handler=1?
> 
> We're checking for either here.

Whoops, read that as &&. carry on!
Comment 6 Mark Lam 2018-10-04 12:24:21 PDT 
Thanks for the review.  Landed in r236839: <http://trac.webkit.org/r236839>.