RESOLVED FIXED 190272
Web Inspector: some files not listed in OpenResourceDialog 
https://bugs.webkit.org/show_bug.cgi?id=190272
Summary Web Inspector: some files not listed in OpenResourceDialog
Devin Rousso
Reported 2018-10-03 19:49:43 PDT
In inspector2, searching for "CanvasSidebarPanel" or "ResourceTreeElement" will only show the CSS files, not the JS files.
Attachments
Patch (7.75 KB, patch)
2018-10-03 20:56 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews103 for mac-sierra (2.37 MB, application/zip)
2018-10-03 21:59 PDT, EWS Watchlist 		no flags
Details
Patch (7.76 KB, patch)
2018-10-03 22:07 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2018-10-03 20:56:05 PDT
Created attachment 351578 [details] Patch Frankly, this is a bit of "wizardry", but it makes sense in my mind (even though I can't quite put it into words). Comments from anyone more familiar with this code would be greatly appreciated :).
Matt Baker
Comment 2 2018-10-03 21:23:44 PDT
(In reply to Devin Rousso from comment #1) > Created attachment 351578 [details] > Patch > > Frankly, this is a bit of "wizardry", but it makes sense in my mind (even > though I can't quite put it into words). Comments from anyone more familiar > with this code would be greatly appreciated :). This is a duplicate, I believe we have an old bug filed for this but I’ll have to look it up. The issue is in the backtracking part of the algorithm. I have a local fix that I just need to write some tests for.
EWS Watchlist
Comment 3 2018-10-03 21:59:51 PDT Comment hidden (obsolete)
EWS Watchlist
Comment 4 2018-10-03 21:59:52 PDT Comment hidden (obsolete)
Devin Rousso
Comment 5 2018-10-03 22:07:46 PDT
Created attachment 351583 [details] Patch
Joseph Pecoraro
Comment 6 2018-10-04 11:41:15 PDT
Comment on attachment 351583 [details] Patch Nice! r=me
WebKit Commit Bot
Comment 7 2018-10-04 13:09:03 PDT
Comment on attachment 351583 [details] Patch Clearing flags on attachment: 351583 Committed r236844: <https://trac.webkit.org/changeset/236844>
WebKit Commit Bot
Comment 8 2018-10-04 13:09:04 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2018-10-04 13:20:03 PDT
<rdar://problem/45019585>
Note You need to log in before you can comment on or make changes to this bug.