Bug 190272 - Web Inspector: some files not listed in OpenResourceDialog
Summary: Web Inspector: some files not listed in OpenResourceDialog
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-03 19:49 PDT by Devin Rousso
Modified: 2018-10-04 13:20 PDT (History)
7 users (show)

See Also:

Attachments
Patch (7.75 KB, patch)
2018-10-03 20:56 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-sierra (2.37 MB, application/zip)
2018-10-03 21:59 PDT, EWS Watchlist 		no flags Details
Patch (7.76 KB, patch)
2018-10-03 22:07 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2018-10-03 19:49:43 PDT 
In inspector2, searching for "CanvasSidebarPanel" or "ResourceTreeElement" will only show the CSS files, not the JS files.
Comment 1 Devin Rousso 2018-10-03 20:56:05 PDT 
Created attachment 351578 [details]
Patch

Frankly, this is a bit of "wizardry", but it makes sense in my mind (even though I can't quite put it into words).  Comments from anyone more familiar with this code would be greatly appreciated :).
Comment 2 Matt Baker 2018-10-03 21:23:44 PDT 
(In reply to Devin Rousso from comment #1)
> Created attachment 351578 [details]
> Patch
> 
> Frankly, this is a bit of "wizardry", but it makes sense in my mind (even
> though I can't quite put it into words).  Comments from anyone more familiar
> with this code would be greatly appreciated :).

This is a duplicate, I believe we have an old bug filed for this but I’ll have to look it up. The issue is in the backtracking part of the algorithm. I have a local fix that I just need to write some tests for.
Comment 3 EWS Watchlist 2018-10-03 21:59:51 PDT Comment hidden (obsolete)
Comment 4 EWS Watchlist 2018-10-03 21:59:52 PDT Comment hidden (obsolete)
Comment 5 Devin Rousso 2018-10-03 22:07:46 PDT 
Created attachment 351583 [details]
Patch
Comment 6 Joseph Pecoraro 2018-10-04 11:41:15 PDT 
Comment on attachment 351583 [details]
Patch

Nice! r=me
Comment 7 WebKit Commit Bot 2018-10-04 13:09:03 PDT 
Comment on attachment 351583 [details]
Patch

Clearing flags on attachment: 351583

Committed r236844: <https://trac.webkit.org/changeset/236844>
Comment 8 WebKit Commit Bot 2018-10-04 13:09:04 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2018-10-04 13:20:03 PDT 
<rdar://problem/45019585>