Bug 190270 – [Cocoa] Let clients specify an NSFileWrapper subclass to be used for _WKAttachment

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

It’s useful if WebKit can make file wrappers of a client-specified subclass of NSFileWrapper. Patch forthcoming.

Created attachment 351571 [details]
Add _attachmentFileWrapperClass property to WKWebViewConfiguration

[EWS Watchlist]

Attachment 351571 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:1458:  Extra space in capture list.  [whitespace/brackets] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:1459:  Extra space in capture list.  [whitespace/brackets] [4]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Wenson Hsieh]

Comment on attachment 351571 [details]
Add _attachmentFileWrapperClass property to WKWebViewConfiguration

View in context: https://bugs.webkit.org/attachment.cgi?id=351571&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:1456
> +    NSPasteboard *pasteboard = NSPasteboard.generalPasteboard;

This is in cross-platform code! Could you just use one of the platform helper functions to write something to the pasteboard (e.g. platformCopyPNG(), platformCopyRichTextWithMultipleAttachments(), etc.) so we can run this on iOS as well?

(In reply to Wenson Hsieh from comment #3)
> Comment on attachment 351571 [details]
> Add _attachmentFileWrapperClass property to WKWebViewConfiguration
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=351571&action=review
> 
> > Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:1456
> > +    NSPasteboard *pasteboard = NSPasteboard.generalPasteboard;
> 
> This is in cross-platform code! Could you just use one of the platform
> helper functions to write something to the pasteboard (e.g.
> platformCopyPNG(), platformCopyRichTextWithMultipleAttachments(), etc.) so
> we can run this on iOS as well?

Sure! For some reason I confused myself into thinking none of those would produce a single _WKAttachment upon paste.

I also need to fix the !WK_API_ENABLED build.

Committed <https://trac.webkit.org/r236822>.

[Radar WebKit Bug Importer]

<rdar://problem/44995423>

[Fujii Hironori]

WinCairo port gets broken.

https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Release%20%28Build%29/builds/3750

> [6/44] Building CXX object Source\WebKit\CMakeFiles\WebKit.dir\UIProcess\win\WebPopupMenuProxyWin.cpp.obj
> FAILED: Source/WebKit/CMakeFiles/WebKit.dir/UIProcess/win/WebPopupMenuProxyWin.cpp.obj 
> "C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.14.26428\bin\Hostx64\x64\cl.exe" (...) -c ..\..\Source\WebKit\UIProcess\win\WebPopupMenuProxyWin.cpp
> C:\WebKit-BuildWorker\wincairo-wkl-release\build\Source\WebKit\UIProcess\PageClient.h(447): error C2143: syntax error: missing ';' before '*'
> C:\WebKit-BuildWorker\wincairo-wkl-release\build\Source\WebKit\UIProcess\PageClient.h(447): error C2433: 'WebKit::PageClient::NSFileWrapper': 'virtual' not permitted on data declarations
> C:\WebKit-BuildWorker\wincairo-wkl-release\build\Source\WebKit\UIProcess\PageClient.h(447): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
> C:\WebKit-BuildWorker\wincairo-wkl-release\build\Source\WebKit\UIProcess\PageClient.h(447): error C2334: unexpected token(s) preceding '{'; skipping apparent function body

(In reply to Fujii Hironori from comment #8)
> WinCairo port gets broken.

Sorry about that! I’ll fix it right away.

(In reply to mitz from comment #9)
> (In reply to Fujii Hironori from comment #8)
> > WinCairo port gets broken.
> 
> Sorry about that! I’ll fix it right away.

Tried to fix it in <https://trac.webkit.org/r236826>.