190264 – [BigInt] Implement ValueBitXor into DFG

RESOLVED FIXED 190264

[BigInt] Implement ValueBitXor into DFG

https://bugs.webkit.org/show_bug.cgi?id=190264

Summary [BigInt] Implement ValueBitXor into DFG

Caio Lima

Reported 2018-10-03 14:58:50 PDT

...

Attachments
WIP - Patch (23.51 KB, patch) 2018-10-06 08:27 PDT, Caio Lima	no flags	Details Formatted Diff Diff
WIP - Patch (24.19 KB, patch) 2018-10-06 11:52 PDT, Caio Lima	no flags	Details Formatted Diff Diff
WIP - Patch (25.40 KB, patch) 2018-10-09 19:49 PDT, Caio Lima	no flags	Details Formatted Diff Diff
Patch (30.78 KB, patch) 2018-10-21 18:48 PDT, Caio Lima	no flags	Details Formatted Diff Diff
Patch (30.91 KB, patch) 2018-10-21 20:05 PDT, Caio Lima	no flags	Details Formatted Diff Diff
Benchmarks (95.28 KB, text/plain) 2018-10-22 04:55 PDT, Caio Lima	no flags	Details
Patch (36.17 KB, patch) 2018-10-31 18:54 PDT, Caio Lima	no flags	Details Formatted Diff Diff
Patch (32.10 KB, patch) 2018-10-31 19:04 PDT, Caio Lima	no flags	Details Formatted Diff Diff
Patch (33.25 KB, patch) 2018-11-01 09:49 PDT, Caio Lima	no flags	Details Formatted Diff Diff
Benchmarks (95.71 KB, text/plain) 2018-11-01 09:50 PDT, Caio Lima	no flags	Details
Patch (33.22 KB, patch) 2018-11-08 06:15 PST, Caio Lima	no flags	Details Formatted Diff Diff
Patch (33.17 KB, patch) 2018-11-12 07:59 PST, Caio Lima	no flags	Details Formatted Diff Diff
Patch (34.69 KB, patch) 2018-11-13 10:41 PST, Caio Lima	no flags	Details Formatted Diff Diff
Patch (33.26 KB, patch) 2018-11-14 08:47 PST, Caio Lima	no flags	Details Formatted Diff Diff
Patch (33.17 KB, patch) 2018-11-18 16:22 PST, Caio Lima	no flags	Details Formatted Diff Diff
Patch (33.17 KB, patch) 2018-11-26 03:11 PST, Caio Lima	no flags	Details Formatted Diff Diff
Patch (33.17 KB, patch) 2018-11-26 03:21 PST, Caio Lima	no flags	Details Formatted Diff Diff
Patch (33.13 KB, patch) 2018-11-28 04:47 PST, Caio Lima	no flags	Details Formatted Diff Diff
Show Obsolete (16) View All Add attachment proposed patch, testcase, etc.

Caio Lima

Comment 1 2018-10-06 08:27:15 PDT

Created attachment 351727 [details] WIP - Patch

Caio Lima

Comment 2 2018-10-06 11:52:11 PDT

Created attachment 351730 [details] WIP - Patch Patch doesn't compile.

Caio Lima

Comment 3 2018-10-09 19:49:24 PDT

Created attachment 351934 [details] WIP - Patch

Caio Lima

Comment 4 2018-10-21 18:48:51 PDT

Created attachment 352878 [details] Patch

Caio Lima

Comment 5 2018-10-21 20:05:44 PDT

Created attachment 352880 [details] Patch

Caio Lima

Comment 6 2018-10-22 04:55:14 PDT

Created attachment 352885 [details] Benchmarks Changes are perf neutral.

Caio Lima

Comment 7 2018-10-31 18:54:30 PDT

Created attachment 353569 [details] Patch

Caio Lima

Comment 8 2018-10-31 19:04:06 PDT

Created attachment 353570 [details] Patch

Caio Lima

Comment 9 2018-11-01 04:41:53 PDT

Comment on attachment 353570 [details] Patch Investigating performance regression

Caio Lima

Comment 10 2018-11-01 09:49:23 PDT

Created attachment 353609 [details] Patch

Caio Lima

Comment 11 2018-11-01 09:50:56 PDT

Created attachment 353611 [details] Benchmarks This patch is perf neutral.

Caio Lima

Comment 12 2018-11-05 06:03:48 PST

Ping Review

Caio Lima

Comment 13 2018-11-08 06:15:55 PST

Created attachment 354235 [details] Patch

EWS Watchlist

Comment 14 2018-11-08 07:43:09 PST

Comment on attachment 354235 [details] Patch Attachment 354235 [details] did not pass jsc-ews (mac): Output: https://webkit-queues.webkit.org/results/9908802 New failing tests: stress/ftl-put-by-id-setter-exception.js.dfg-eager-no-cjit-validate apiTests

Caio Lima

Comment 15 2018-11-12 07:59:56 PST

Created attachment 354559 [details] Patch

Caio Lima

Comment 16 2018-11-13 10:41:52 PST

Created attachment 354681 [details] Patch

Caio Lima

Comment 17 2018-11-14 08:47:07 PST

Created attachment 354813 [details] Patch

Caio Lima

Comment 18 2018-11-18 16:22:45 PST

Created attachment 355243 [details] Patch

Caio Lima

Comment 19 2018-11-19 16:32:35 PST

Ping review

Caio Lima

Comment 20 2018-11-26 03:11:59 PST

Created attachment 355629 [details] Patch

Caio Lima

Comment 21 2018-11-26 03:21:59 PST

Created attachment 355630 [details] Patch

Caio Lima

Comment 22 2018-11-28 04:47:05 PST

Created attachment 355863 [details] Patch

Yusuke Suzuki

Comment 23 2018-11-29 17:53:17 PST

Comment on attachment 355863 [details] Patch r=me

WebKit Commit Bot

Comment 24 2018-11-30 05:25:01 PST

Comment on attachment 355863 [details] Patch Clearing flags on attachment: 355863 Committed r238732: <https://trac.webkit.org/changeset/238732>

WebKit Commit Bot

Comment 25 2018-11-30 05:25:03 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 26 2018-11-30 05:26:39 PST

<rdar://problem/46371247>

Saam Barati

Comment 27 2019-01-20 13:03:40 PST

Comment on attachment 355863 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355863&action=review > Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:398 > + case ValueBitXor: > case ValueBitAnd: > + case ValueBitOr: Can we add constant folding for this in the future if the inputs are constant? > Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:167 > + case ArithBitXor: > + node->setOpAndDefaultFlags(ValueBitXor); > + break; Did we end up switching this back to be the opposite direction? First emit ValueBitXor, then optimize to ArithBitXor.

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component JavaScriptCore

Assignee

Caio Lima

Reported

2018-10-03 14:58 PDT

Modified

2019-01-20 13:03 PST History

CC List

8 users Show

URL

Keywords InRadar

Depends on

186235

Blocks

186173

Dependencies

tree graph