RESOLVED FIXED 190260
[iOS] Pressing space bar outside editable content is handled twice 
https://bugs.webkit.org/show_bug.cgi?id=190260
Summary [iOS] Pressing space bar outside editable content is handled twice
Daniel Bates
Reported 2018-10-03 13:35:51 PDT
Using a debugger, perform the following: 1. Set a breakpoint at <https://trac.webkit.org/browser/trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm?rev=236303#L3125>, have it log "%B" and continue automatically. 2. Set a breakpoint at <https://trac.webkit.org/browser/trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm?rev=236303#L3731>, have it log "%B keyDown: @event._isKeyDown@" and continue automatically. 3. Set a breakpoint at <https://trac.webkit.org/browser/trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm?rev=236303#L3742>, have it log "%B Skipping" and continue automatically. 4. Launch MobileSafari, visit nytimes.com and let it completely load. 5. Press and hold the space bar for a few seconds. I see the following debugger output: -_handleKeyUIEvent: keyDown: YES -_arrowKeyForWebView: -handleKeyEvent: Skipping -_arrowKeyForWebView: -_arrowKeyForWebView: -_arrowKeyForWebView: -_arrowKeyForWebView: -_arrowKeyForWebView: -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: YES -_handleKeyUIEvent: keyDown: NO
Attachments
Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2018-10-03 13:36:51 PDT
From the debugger output in comment #1 we see that the space bar is handled both by -_handleKeyUIEvent and -_arrowKeyForWebView.
Radar WebKit Bug Importer
Comment 2 2018-10-04 13:14:26 PDT
<rdar://problem/45019421>
Daniel Bates
Comment 3 2018-10-14 22:08:55 PDT
This issue was fixed in the patch for bug #190345.
Note You need to log in before you can comment on or make changes to this bug.