Bug 190259 - Web Automation: clear pending callbacks when the session terminates
Summary: Web Automation: clear pending callbacks when the session terminates
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebDriver (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-03 13:23 PDT by BJ Burg
Modified: 2018-10-04 14:47 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.72 KB, patch)
2018-10-03 13:32 PDT, BJ Burg
joepeck: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2018-10-03 13:23:54 PDT
In some cases, the UIProcess may assert when completion handlers are not called and are instead destructed via WebAutomationSession::~WebAutomationSession.
Comment 1 BJ Burg 2018-10-03 13:24:26 PDT
<rdar://problem/44958352>
Comment 2 BJ Burg 2018-10-03 13:32:11 PDT
Created attachment 351543 [details]
Patch
Comment 3 Joseph Pecoraro 2018-10-04 12:58:39 PDT
Comment on attachment 351543 [details]
Patch

r=me
Comment 4 BJ Burg 2018-10-04 14:47:27 PDT
Committed r236852: <https://trac.webkit.org/changeset/236852>