Bug 190248 – [LayoutTests][Win] Stop wpt server correctly.

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Basuke Suzuki]

The wpt test server wasn't killed correctly which keep opening the log files and prevent following `archive-test-results` command. It is caused by mis-implementation of executive.interrupt().

[Basuke Suzuki]

Created attachment 351518 [details]
PATCH

[EWS Watchlist]

Attachment 351518 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/common/system/executive.py:312:  [Executive.interrupt] Module 'signal' has no 'CTRL_C_EVENT' member  [pylint/E1101] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Basuke Suzuki]

(In reply to Build Bot from comment #2)
> Attachment 351518 [details] did not pass style-queue:
> 
> 
> ERROR: Tools/Scripts/webkitpy/common/system/executive.py:312: 
> [Executive.interrupt] Module 'signal' has no 'CTRL_C_EVENT' member 
> [pylint/E1101] [5]
> Total errors found: 1 in 2 files
> 
> 
> If any of these errors are false positives, please file a bug against
> check-webkit-style.

This is false positive. The constant is available only on Windows.
https://docs.python.org/2/library/signal.html#signal.CTRL_C_EVENT

[Don Olmstead]

Comment on attachment 351518 [details]
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=351518&action=review

Informal review is good. Just wondering if there's any way to just check if its windows native or cygwin in one line.

> Tools/Scripts/webkitpy/common/system/executive.py:487
> +        if self._is_cygwin or self._is_native_win:

Is there any query for both at the same time? This is repeated in a couple places.

[Basuke Suzuki]

Comment on attachment 351518 [details]
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=351518&action=review

>> Tools/Scripts/webkitpy/common/system/executive.py:487
>> +        if self._is_cygwin or self._is_native_win:
> 
> Is there any query for both at the same time? This is repeated in a couple places.

In platformInfo, is_win() is also defined so that it should be. But after writing the code, I didn't read this code hard. I am okay for both.

[Fujii Hironori]

I also confirmed your patch solves the pywebsocket.ws.log-err.txt issue (Bug 190236). Thank you for working on this.

[Fujii Hironori]

*** Bug 190236 has been marked as a duplicate of this bug. ***

[WebKit Commit Bot]

Comment on attachment 351518 [details]
PATCH

Clearing flags on attachment: 351518

Committed r236835: <https://trac.webkit.org/changeset/236835>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/45011998>