Bug 190247 – [WPE][GTK] API test runner fails to respect default build type

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Michael Catanzaro]

$ run-gtk-tests
No handlers could be found for logger "webkitpy.thirdparty.autoinstalled.keyring.backend"
Could not determine build directory.


Problem is it's looking for a release build, even though I've run set-webkit-configuration --debug. It should look for a debug build unless I explicitly pass --release.

[Michael Catanzaro]

Created attachment 351517 [details]
Patch

[Adrian Perez]

Comment on attachment 351517 [details]
Patch

LGTM, informally.

[Carlos Garcia Campos]

Comment on attachment 351517 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351517&action=review

> Tools/glib/api_test_runner.py:51
> +        if self._options.debug:
> +            self._build_type = "Debug"
> +        elif self._options.release:
> +            self._build_type = "Release"
> +        else:
> +            self._build_type = self._port.default_configuration()
> +        common.set_build_types((self._build_type,))

Why did you move this after the port and driver initialization?

[Michael Catanzaro]

Comment on attachment 351517 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351517&action=review

>> Tools/glib/api_test_runner.py:51
>> +        common.set_build_types((self._build_type,))
> 
> Why did you move this after the port and driver initialization?

To be able to use self._port on the line above!

[WebKit Commit Bot]

Comment on attachment 351517 [details]
Patch

Clearing flags on attachment: 351517

Committed r237805: <https://trac.webkit.org/changeset/237805>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.