$ run-gtk-tests No handlers could be found for logger "webkitpy.thirdparty.autoinstalled.keyring.backend" Could not determine build directory. Problem is it's looking for a release build, even though I've run set-webkit-configuration --debug. It should look for a debug build unless I explicitly pass --release.
Created attachment 351517 [details] Patch
Comment on attachment 351517 [details] Patch LGTM, informally.
Comment on attachment 351517 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351517&action=review > Tools/glib/api_test_runner.py:51 > + if self._options.debug: > + self._build_type = "Debug" > + elif self._options.release: > + self._build_type = "Release" > + else: > + self._build_type = self._port.default_configuration() > + common.set_build_types((self._build_type,)) Why did you move this after the port and driver initialization?
Comment on attachment 351517 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351517&action=review >> Tools/glib/api_test_runner.py:51 >> + common.set_build_types((self._build_type,)) > > Why did you move this after the port and driver initialization? To be able to use self._port on the line above!
Comment on attachment 351517 [details] Patch Clearing flags on attachment: 351517 Committed r237805: <https://trac.webkit.org/changeset/237805>
All reviewed patches have been landed. Closing bug.