Bug 190240 - Clear m_pendingTargets in MutationObserver::takeRecords
Summary: Clear m_pendingTargets in MutationObserver::takeRecords
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-03 02:01 PDT by Ryosuke Niwa
Modified: 2018-10-03 20:55 PDT (History)
12 users (show)

See Also:

Attachments
Cleanup (5.83 KB, patch)
2018-10-03 02:11 PDT, Ryosuke Niwa 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2018-10-03 02:01:32 PDT 
https://trac.webkit.org/r236781 delayed the clearing of m_pendingTargets until the end of microtask
to avoid a race between JSMutationRecord's wrappers to be created and GC.

Cleanup this code so that we don't have to delay the clearing until the end of Microtask.
Comment 1 Ryosuke Niwa 2018-10-03 02:11:29 PDT 
Created attachment 351496 [details]
Cleanup
Comment 2 Geoffrey Garen 2018-10-03 15:13:43 PDT 
Comment on attachment 351496 [details]
Cleanup

r=me

Can you add a bindings test for this?

Here are two alternative names to consider:

[ResultField=records]
[ResultExtractor=result.records]
Comment 3 Radar WebKit Bug Importer 2018-10-03 20:51:01 PDT 
<rdar://problem/44997466>
Comment 4 Ryosuke Niwa 2018-10-03 20:52:14 PDT 
(In reply to Geoffrey Garen from comment #2)
> Comment on attachment 351496 [details]
> Cleanup
> 
> r=me
> 
> Can you add a bindings test for this?

Will do.

> Here are two alternative names to consider:
> 
> [ResultField=records]
> [ResultExtractor=result.records]

Will use ResultField.
Comment 5 Ryosuke Niwa 2018-10-03 20:55:14 PDT 
Committed r236825: <https://trac.webkit.org/changeset/236825>