Bug 190232 – [iOS] [WK2] Expose some more editing SPI on WKWebView

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Wenson Hsieh]

Expose more editing SPI on WKWebView, for internal use by rich text editors on iOS.

[Wenson Hsieh]

This includes a way to specify font colors, as well as a UIFont.

[Radar WebKit Bug Importer]

<rdar://problem/44963368>

[Wenson Hsieh]

Created attachment 351474 [details]
Patch

Comment on attachment 351474 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351474&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:371
> +@interface WKWebView (EditActions) <UIResponderStandardEditActions>

Unprefixed category names on API classes are reserved for client apps. WebKit’s categories should be prefixed WK. Although this could just be a class extension rather than a named category.

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:382
> +- (void)setFont:(UIFont *)font withSender:(id)sender;
> +- (void)setTextColor:(UIColor *)color withSender:(id)sender;

Not sure how “with” fits here.

[Wenson Hsieh]

Comment on attachment 351474 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351474&action=review

>> Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:371
>> +@interface WKWebView (EditActions) <UIResponderStandardEditActions>
> 
> Unprefixed category names on API classes are reserved for client apps. WebKit’s categories should be prefixed WK. Although this could just be a class extension rather than a named category.

Good point! I'll change this to just be a class extension (i.e. WKWebView () <…>)

>> Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:382
>> +- (void)setTextColor:(UIColor *)color withSender:(id)sender;
> 
> Not sure how “with” fits here.

I suppose the "with" doesn't add anything here except more keystrokes :P

Removed the "with"

[Wenson Hsieh]

Comment on attachment 351474 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351474&action=review

>>> Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:382
>>> +- (void)setTextColor:(UIColor *)color withSender:(id)sender;
>> 
>> Not sure how “with” fits here.
> 
> I suppose the "with" doesn't add anything here except more keystrokes :P
> 
> Removed the "with"

(Ah, I recall now — I was initially inspired to add the "with" by `- (BOOL)canPerformAction:(SEL)action withSender:(nullable id)sender` on UIResponder).

[Wenson Hsieh]

Created attachment 351478 [details]
Patch

[Wenson Hsieh]

Created attachment 351479 [details]
Update ChangeLog

[Wenson Hsieh]

Created attachment 351535 [details]
Add setFontSize:sender:

[Wenson Hsieh]

Created attachment 351649 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 351649 [details]
Patch for landing

Clearing flags on attachment: 351649

Committed r236867: <https://trac.webkit.org/changeset/236867>