There's no reason to have them separate, especially since DebuggerManager controls most of ProbeManager's functionality.
Created attachment 351453 [details] Patch
Comment on attachment 351453 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351453&action=review r- > Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js:1276 > + this._breakpointAdded(breakpoint); This appears to call _breakpointAdded which doesn't exist anymore... Given the subtlety in renaming and moving things this might need more work. It is unclear all of the changes that happened in this merge.
Comment on attachment 351453 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351453&action=review >> Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js:1276 >> + this._breakpointAdded(breakpoint); > > This appears to call _breakpointAdded which doesn't exist anymore... Given the subtlety in renaming and moving things this might need more work. It is unclear all of the changes that happened in this merge. Most of the changes (outside of copypasta) are basic modernization (e.g. `var` to `let`). Functionality should be unchanged.
Created attachment 351462 [details] Patch
Comment on attachment 351462 [details] Patch Attachment 351462 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9434667 New failing tests: inspector/debugger/tail-deleted-frames.html inspector/debugger/probe-manager-add-remove-actions.html inspector/debugger/tail-recursion.html inspector/debugger/pause-reason.html inspector/worker/debugger-pause.html inspector/debugger/breakpoint-columns.html inspector/debugger/tail-deleted-frames-this-value.html inspector/debugger/tail-deleted-frames-from-vm-entry.html inspector/debugger/breakpoint-scope.html inspector/debugger/debugger-stack-overflow.html
Created attachment 351466 [details] Archive of layout-test-results from ews103 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 351462 [details] Patch Attachment 351462 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9434975 New failing tests: inspector/debugger/tail-deleted-frames.html inspector/debugger/probe-manager-add-remove-actions.html inspector/debugger/tail-recursion.html inspector/debugger/pause-reason.html inspector/worker/debugger-pause.html inspector/debugger/breakpoint-columns.html inspector/debugger/tail-deleted-frames-this-value.html inspector/debugger/tail-deleted-frames-from-vm-entry.html inspector/debugger/breakpoint-scope.html inspector/debugger/debugger-stack-overflow.html
Created attachment 351469 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 351462 [details] Patch Attachment 351462 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9434983 New failing tests: inspector/worker/debugger-pause.html inspector/debugger/tail-deleted-frames.html inspector/debugger/probe-manager-add-remove-actions.html inspector/debugger/pause-reason.html inspector/debugger/tail-deleted-frames-from-vm-entry.html
Created attachment 351470 [details] Archive of layout-test-results from ews114 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 351477 [details] Patch Typo :(
Comment on attachment 351477 [details] Patch r=me
Comment on attachment 351477 [details] Patch Clearing flags on attachment: 351477 Committed r236845: <https://trac.webkit.org/changeset/236845>
All reviewed patches have been landed. Closing bug.
<rdar://problem/45020758>