RESOLVED FIXED 190224
Web Inspector: merge SourceMapManager into NetworkManager 
https://bugs.webkit.org/show_bug.cgi?id=190224
Summary Web Inspector: merge SourceMapManager into NetworkManager
Devin Rousso
Reported 2018-10-02 16:22:00 PDT
There's no reason to have them separate, especially since NetworkManager controls most of SourceMapManager's functionality.
Attachments
Patch (22.08 KB, patch)
2018-10-02 16:28 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (22.03 KB, patch)
2018-10-02 17:40 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2018-10-02 16:28:27 PDT
Created attachment 351451 [details] Patch
Joseph Pecoraro
Comment 2 2018-10-02 16:46:55 PDT
Comment on attachment 351451 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351451&action=review r=me > Source/WebInspectorUI/UserInterface/Controllers/NetworkManager.js:41 > + this._sourceMapURLMap = {}; > + this._downloadingSourceMaps = {}; We could modernize this to be a Map and Set. That can be another time. > Source/WebInspectorUI/UserInterface/Controllers/NetworkManager.js:389 > - WI.sourceMapManager.downloadSourceMap(cachedResourcePayload.sourceMapURL, resource.url, resource); > + WI.networkManager.downloadSourceMap(cachedResourcePayload.sourceMapURL, resource.url, resource); Shouldn't these just be `this.` instead of `WI.networkManager.`?
Devin Rousso
Comment 3 2018-10-02 17:40:54 PDT
Created attachment 351461 [details] Patch
WebKit Commit Bot
Comment 4 2018-10-02 18:49:13 PDT
Comment on attachment 351461 [details] Patch Clearing flags on attachment: 351461 Committed r236783: <https://trac.webkit.org/changeset/236783>
WebKit Commit Bot
Comment 5 2018-10-02 18:49:14 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-10-02 18:50:28 PDT
<rdar://problem/44961679>
Note You need to log in before you can comment on or make changes to this bug.