Bug 190224 - Web Inspector: merge SourceMapManager into NetworkManager
Summary: Web Inspector: merge SourceMapManager into NetworkManager
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks: 190276
  Show dependency treegraph
 
Reported: 2018-10-02 16:22 PDT by Devin Rousso
Modified: 2018-10-03 22:53 PDT (History)
4 users (show)

See Also:


Attachments
Patch (22.08 KB, patch)
2018-10-02 16:28 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (22.03 KB, patch)
2018-10-02 17:40 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2018-10-02 16:22:00 PDT
There's no reason to have them separate, especially since NetworkManager controls most of SourceMapManager's functionality.
Comment 1 Devin Rousso 2018-10-02 16:28:27 PDT
Created attachment 351451 [details]
Patch
Comment 2 Joseph Pecoraro 2018-10-02 16:46:55 PDT
Comment on attachment 351451 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351451&action=review

r=me

> Source/WebInspectorUI/UserInterface/Controllers/NetworkManager.js:41
> +        this._sourceMapURLMap = {};
> +        this._downloadingSourceMaps = {};

We could modernize this to be a Map and Set. That can be another time.

> Source/WebInspectorUI/UserInterface/Controllers/NetworkManager.js:389
> -            WI.sourceMapManager.downloadSourceMap(cachedResourcePayload.sourceMapURL, resource.url, resource);
> +            WI.networkManager.downloadSourceMap(cachedResourcePayload.sourceMapURL, resource.url, resource);

Shouldn't these just be `this.` instead of `WI.networkManager.`?
Comment 3 Devin Rousso 2018-10-02 17:40:54 PDT
Created attachment 351461 [details]
Patch
Comment 4 WebKit Commit Bot 2018-10-02 18:49:13 PDT
Comment on attachment 351461 [details]
Patch

Clearing flags on attachment: 351461

Committed r236783: <https://trac.webkit.org/changeset/236783>
Comment 5 WebKit Commit Bot 2018-10-02 18:49:14 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-10-02 18:50:28 PDT
<rdar://problem/44961679>