Bug 190221 – Web Automation: tab default key handler should always cycle focus when page is controlled by automation

• Status: RESOLVED
• Resolution: FIXED
• Component: UI Events

[Blaze Burg]

.

[Blaze Burg]

<rdar://problem/44914534>

[Blaze Burg]

Created attachment 351445 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 351445 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351445&action=review

r=me

> Source/WebCore/ChangeLog:15
> +        Always cycle focus if the page is controlled by automation. If the chrome takes
> +        focus, then the first responder will be something other than the WebView, which
> +        causes subsequent WebDriver commands to hang.

Hmm, this is interesting and makes sense but doesn't that mean that the test might differ from a real user behavior on the page?

[Blaze Burg]

(In reply to Joseph Pecoraro from comment #3)
> Comment on attachment 351445 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=351445&action=review
> 
> r=me
> 
> > Source/WebCore/ChangeLog:15
> > +        Always cycle focus if the page is controlled by automation. If the chrome takes
> > +        focus, then the first responder will be something other than the WebView, which
> > +        causes subsequent WebDriver commands to hang.
> 
> Hmm, this is interesting and makes sense but doesn't that mean that the test
> might differ from a real user behavior on the page?

Yes, it does, though I don't know that wraparound is in anyway specified by a standard.

There are many other differences between WebDriver and normal UA behavior, the largest being how alerts are handled.

[Blaze Burg]

Committed r236774: <https://trac.webkit.org/changeset/236774>