Bug 190218 - fieldset.elements should return an HTMLCollection instead of an HTMLFormControlsCollection
Summary: fieldset.elements should return an HTMLCollection instead of an HTMLFormContr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://github.com/whatwg/html/commit...
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-02 13:35 PDT by Chris Dumez
Modified: 2018-10-02 17:27 PDT (History)
9 users (show)

See Also:

Attachments
Patch (34.11 KB, patch)
2018-10-02 13:57 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (34.29 KB, patch)
2018-10-02 15:51 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-10-02 13:35:17 PDT 
fieldset.elements should return an HTMLCollection instead of an HTMLFormControlsCollection:
- https://github.com/whatwg/html/commit/8beedf0c2ffd38853caddec67490288f47afc8eb

Gecko has already behaved this way. Blink aligned with Gecko and the HTML specification in December 2016:
- https://bugs.chromium.org/p/chromium/issues/detail?id=665291
Comment 1 Chris Dumez 2018-10-02 13:37:27 PDT 
Test case:
http://w3c-test.org/html/semantics/forms/the-fieldset-element/HTMLFieldSetElement.html

Passes in both Chrome and Firefox, fails in Safari.
Comment 2 Chris Dumez 2018-10-02 13:57:14 PDT 
Created attachment 351436 [details]
Patch
Comment 3 Chris Dumez 2018-10-02 15:51:10 PDT 
Created attachment 351449 [details]
Patch
Comment 4 WebKit Commit Bot 2018-10-02 17:26:49 PDT 
Comment on attachment 351449 [details]
Patch

Clearing flags on attachment: 351449

Committed r236778: <https://trac.webkit.org/changeset/236778>
Comment 5 WebKit Commit Bot 2018-10-02 17:26:50 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-10-02 17:27:28 PDT 
<rdar://problem/44959731>