Bug 190203 - Fix Disassembler-output on ARM Thumb2
Summary: Fix Disassembler-output on ARM Thumb2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-02 08:54 PDT by Dominik Inführ
Modified: 2018-10-02 15:54 PDT (History)
9 users (show)

See Also:

Attachments
Patch (1.64 KB, patch)
2018-10-02 09:11 PDT, Dominik Inführ 		no flags Details | Formatted Diff | Diff
Patch (2.00 KB, patch)
2018-10-02 15:11 PDT, Dominik Inführ 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dominik Inführ 2018-10-02 08:54:18 PDT 
Fix Disassembler-output on ARM Thumb2
Comment 1 Dominik Inführ 2018-10-02 09:11:48 PDT 
Created attachment 351395 [details]
Patch
Comment 2 Yusuke Suzuki 2018-10-02 09:18:48 PDT 
Comment on attachment 351395 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351395&action=review

> Source/JavaScriptCore/ChangeLog:6
> +        Disassembler on ARM-Thumb2 started on wrong address.

Please describe the detail about what was wrong and what this patch fixes :)
Comment 3 Dominik Inführ 2018-10-02 15:11:47 PDT 
Created attachment 351444 [details]
Patch
Comment 4 Dominik Inführ 2018-10-02 15:13:15 PDT 
Sorry ;) Updated the ChangeLog. Thanks a lot!
Comment 5 Mark Lam 2018-10-02 15:13:37 PDT 
Comment on attachment 351444 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2018-10-02 15:53:34 PDT 
Comment on attachment 351444 [details]
Patch

Clearing flags on attachment: 351444

Committed r236768: <https://trac.webkit.org/changeset/236768>
Comment 7 WebKit Commit Bot 2018-10-02 15:53:36 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-10-02 15:54:23 PDT 
<rdar://problem/44956795>