Bug 190173 - Add support for MediaKeyEncryptionScheme
Summary: Add support for MediaKeyEncryptionScheme
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-01 15:39 PDT by Jer Noble
Modified: 2018-10-18 14:44 PDT (History)
4 users (show)

See Also:

Attachments
Patch (30.32 KB, patch)
2018-10-01 15:44 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (30.96 KB, patch)
2018-10-18 12:48 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2018-10-01 15:39:50 PDT 
Add support for MediaKeyEncryptionScheme
Comment 1 Jer Noble 2018-10-01 15:44:06 PDT 
Created attachment 351316 [details]
Patch
Comment 2 EWS Watchlist 2018-10-01 15:46:46 PDT 
Attachment 351316 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/encryptedmedia/CDMEncryptionScheme.h:33:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/encryptedmedia/CDMEncryptionScheme.h:34:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 2 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Radar WebKit Bug Importer 2018-10-01 16:08:44 PDT 
<rdar://problem/44924613>
Comment 4 Jer Noble 2018-10-18 12:48:00 PDT 
Created attachment 352717 [details]
Patch for landing
Comment 5 EWS Watchlist 2018-10-18 12:49:43 PDT 
Attachment 352717 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/encryptedmedia/CDMEncryptionScheme.h:33:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/encryptedmedia/CDMEncryptionScheme.h:34:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 2 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 WebKit Commit Bot 2018-10-18 14:44:33 PDT 
Comment on attachment 352717 [details]
Patch for landing

Clearing flags on attachment: 352717

Committed r237268: <https://trac.webkit.org/changeset/237268>
Comment 7 WebKit Commit Bot 2018-10-18 14:44:35 PDT 
All reviewed patches have been landed.  Closing bug.