Bug 190170 - REGRESSION(r236624): Crash in PlaybackSessionInterfaceContext::isPictureInPictureSupportedChanged(bool) in WKTR
Summary: REGRESSION(r236624): Crash in PlaybackSessionInterfaceContext::isPictureInPic...
Status: RESOLVED DUPLICATE of bug 188747
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on: 188747
Blocks:
  Show dependency tree / graph
 
Reported: 2018-10-01 15:17 PDT by Jer Noble
Modified: 2018-10-05 10:10 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.99 KB, patch)
2018-10-01 15:28 PDT, Jer Noble 		ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-sierra-wk2 (3.21 MB, application/zip)
2018-10-01 17:36 PDT, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2018-10-01 15:17:38 PDT 
REGRESSION(r236624): Crash in PlaybackSessionInterfaceContext::isPictureInPictureSupportedChanged(bool) in WKTR
Comment 1 Jer Noble 2018-10-01 15:28:08 PDT 
Created attachment 351314 [details]
Patch
Comment 2 EWS Watchlist 2018-10-01 17:36:55 PDT 
Comment on attachment 351314 [details]
Patch

Attachment 351314 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9419376

New failing tests:
media/range-extract-contents-crash.html
Comment 3 EWS Watchlist 2018-10-01 17:36:57 PDT 
Created attachment 351327 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 4 Ryan Haddad 2018-10-01 17:37:56 PDT 
(In reply to Build Bot from comment #2)
> Comment on attachment 351314 [details]
> Patch
> 
> Attachment 351314 [details] did not pass mac-wk2-ews (mac-wk2):
> Output: https://webkit-queues.webkit.org/results/9419376
> 
> New failing tests:
> media/range-extract-contents-crash.html

Application Specific Information:
CRASHING TEST: media/range-extract-contents-crash.html

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   ???                           	000000000000000000 0 + 0
1   com.apple.WebKit              	0x000000010f83466d WebKit::PlaybackSessionModelContext::externalPlaybackChanged(bool, WebCore::PlaybackSessionModel::ExternalPlaybackTargetType, WTF::String const&) + 185 (Vector.h:1504)
2   com.apple.WebKit              	0x000000010f6dc46e void IPC::callMemberFunctionImpl<WebKit::PlaybackSessionManagerProxy, void (WebKit::PlaybackSessionManagerProxy::*)(unsigned long long, bool, unsigned int, WTF::String), std::__1::tuple<unsigned long long, bool, unsigned int, WTF::String>, 0ul, 1ul, 2ul, 3ul>(WebKit::PlaybackSessionManagerProxy*, void (WebKit::PlaybackSessionManagerProxy::*)(unsigned long long, bool, unsigned int, WTF::String), std::__1::tuple<unsigned long long, bool, unsigned int, WTF::String>&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul, 2ul, 3ul>) + 66 (utility:753)
3   com.apple.WebKit              	0x000000010f6db401 void IPC::handleMessage<Messages::PlaybackSessionManagerProxy::ExternalPlaybackPropertiesChanged, WebKit::PlaybackSessionManagerProxy, void (WebKit::PlaybackSessionManagerProxy::*)(unsigned long long, bool, unsigned int, WTF::String)>(IPC::Decoder&, WebKit::PlaybackSessionManagerProxy*, void (WebKit::PlaybackSessionManagerProxy::*)(unsigned long long, bool, unsigned int, WTF::String)) + 73 (utility:753)
4   com.apple.WebKit              	0x000000010f6b6505 IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&) + 127 (MessageReceiverMap.cpp:123)
5   com.apple.WebKit              	0x000000010f8addbc WebKit::WebProcessProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) + 24 (WebProcessProxy.cpp:650)
6   com.apple.WebKit              	0x000000010f6a7606 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) + 108 (memory:2714)
7   com.apple.WebKit              	0x000000010f6aa259 IPC::Connection::dispatchIncomingMessages() + 833 (memory:2734)
8   com.apple.JavaScriptCore      	0x000000010e2e41f6 WTF::RunLoop::performWork() + 214 (Function.h:56)
9   com.apple.JavaScriptCore      	0x000000010e2e4512 WTF::RunLoop::performWork(void*) + 34 (RunLoopCF.cpp:39)
10  com.apple.CoreFoundation      	0x00007fff881703e1 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
11  com.apple.CoreFoundation      	0x00007fff8815165c __CFRunLoopDoSources0 + 556
12  com.apple.CoreFoundation      	0x00007fff88150b46 __CFRunLoopRun + 934
13  com.apple.CoreFoundation      	0x00007fff88150544 CFRunLoopRunSpecific + 420
14  com.apple.Foundation          	0x00007fff89b81252 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 277
15  WebKitTestRunner              	0x000000010e219261 WTR::TestController::platformRunUntil(bool&, WTF::Seconds) + 191 (TestControllerCocoa.mm:204)
16  WebKitTestRunner              	0x000000010e21a365 WTR::TestInvocation::invoke() + 305 (TestInvocation.cpp:179)
17  WebKitTestRunner              	0x000000010e20f931 WTR::TestController::runTest(char const*) + 2205 (TestController.cpp:1379)
18  WebKitTestRunner              	0x000000010e20fc92 WTR::TestController::runTestingServerLoop() + 132 (TestController.cpp:1408)
19  WebKitTestRunner              	0x000000010e20a084 WTR::TestController::TestController(int, char const**) + 310 (TestController.cpp:147)
20  WebKitTestRunner              	0x000000010e1f9d5c main + 657 (main.mm:68)
21  libdyld.dylib                 	0x00007fff9dd22235 start + 1
Comment 5 Alex Christensen 2018-10-02 09:27:24 PDT 
That test failure looks quite suspicious.
Comment 6 Ryan Haddad 2018-10-02 10:12:46 PDT 
The change that introduced the regression was rolled out in https://trac.webkit.org/changeset/236748/webkit.

*** This bug has been marked as a duplicate of bug 188747 ***