Bug 190168 - [WebVTT] Cue with line setting is not rendered correctly
Summary: [WebVTT] Cue with line setting is not rendered correctly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-01 15:03 PDT by Per Arne Vollan
Modified: 2023-08-18 04:29 PDT (History)
7 users (show)

See Also:


Attachments
Patch (8.35 KB, patch)
2018-10-01 15:14 PDT, Per Arne Vollan
eric.carlson: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-sierra-wk2 (3.06 MB, application/zip)
2018-10-01 17:32 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews100 for mac-sierra (2.70 MB, application/zip)
2018-10-01 18:15 PDT, EWS Watchlist
no flags Details
Patch (8.74 KB, patch)
2018-10-02 09:25 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff
Patch (8.73 KB, patch)
2018-10-02 09:28 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2018-10-01 15:03:13 PDT
When the line setting contains an optional alignment value, the cue is not rendered at the correct position, see https://w3c.github.io/webvtt/#webvtt-line-cue-setting.
Comment 1 Per Arne Vollan 2018-10-01 15:14:03 PDT
Created attachment 351312 [details]
Patch
Comment 2 Per Arne Vollan 2018-10-01 15:14:51 PDT
rdar://problem/44384699
Comment 3 EWS Watchlist 2018-10-01 17:32:38 PDT
Comment on attachment 351312 [details]
Patch

Attachment 351312 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9419303

New failing tests:
media/track/track-cue-line-position.html
Comment 4 EWS Watchlist 2018-10-01 17:32:39 PDT
Created attachment 351326 [details]
Archive of layout-test-results from ews105 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 5 EWS Watchlist 2018-10-01 18:15:50 PDT
Comment on attachment 351312 [details]
Patch

Attachment 351312 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9419729

New failing tests:
media/track/track-cue-line-position.html
Comment 6 EWS Watchlist 2018-10-01 18:15:51 PDT
Created attachment 351332 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 7 Eric Carlson 2018-10-02 01:54:17 PDT
Comment on attachment 351312 [details]
Patch

r=me once the bots are happy
Comment 8 Per Arne Vollan 2018-10-02 09:25:59 PDT
Created attachment 351397 [details]
Patch
Comment 9 Per Arne Vollan 2018-10-02 09:28:40 PDT
Created attachment 351398 [details]
Patch
Comment 10 Per Arne Vollan 2018-10-02 11:10:35 PDT
Comment on attachment 351398 [details]
Patch

Thanks for reviewing!
Comment 11 WebKit Commit Bot 2018-10-02 11:36:39 PDT
Comment on attachment 351398 [details]
Patch

Clearing flags on attachment: 351398

Committed r236754: <https://trac.webkit.org/changeset/236754>
Comment 12 Ahmad Saleem 2023-08-18 04:29:31 PDT
Landed: https://github.com/WebKit/WebKit/commit/0fcc46fa5d81f8572e9841ef88dcf81f59b39aba

Marking this as 'RESOLVED FIXED'. Thanks!