Bug 190157 - Don't read from WebCore's bundle for IDNScriptWhiteList
Summary: Don't read from WebCore's bundle for IDNScriptWhiteList
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-01 14:21 PDT by Alex Christensen
Modified: 2018-10-01 17:22 PDT (History)
4 users (show)

See Also:

Attachments
Patch (8.67 KB, patch)
2018-10-01 14:23 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (8.76 KB, patch)
2018-10-01 14:50 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (7.93 KB, patch)
2018-10-01 16:08 PDT, Alex Christensen 		mitz: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-10-01 14:21:56 PDT 
Don't read from a file for IDNScriptWhiteList
Comment 1 Alex Christensen 2018-10-01 14:23:22 PDT 
Created attachment 351298 [details]
Patch
Comment 2 Alex Christensen 2018-10-01 14:50:38 PDT 
Created attachment 351307 [details]
Patch
Comment 3 mitz 2018-10-01 15:54:06 PDT 
Comment on attachment 351307 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351307&action=review

> Source/WebCore/ChangeLog:8
> +        No change in behavior.  This increases performance by not reading from a file,

Can you explain how the behavior where if a whitelist is placed in /Library or ~/Library, its contents is used instead of the built-in list is maintained with this change?
Comment 4 Alex Christensen 2018-10-01 16:08:13 PDT 
Created attachment 351319 [details]
Patch
Comment 5 Alex Christensen 2018-10-01 17:21:26 PDT 
http://trac.webkit.org/r236703
Comment 6 Radar WebKit Bug Importer 2018-10-01 17:22:23 PDT 
<rdar://problem/44926790>