Bug 190153 – Convert tests to use navigation client

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Michael Catanzaro]

[4613/4761] Building CXX object Tools/TestWebKitAPI...r/Tests/WebKit/DownloadDecideDestinationCrash.cpp.o
../../Tools/TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp: In function ‘void TestWebKitAPI::setPagePolicyClient(WKPageRef)’:
../../Tools/TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:69:55: warning: ‘void WKPageSetPagePolicyClient(WKPageRef, const WKPagePolicyClientBase*)’ is deprecated: use WKPageSetPageNavigationClient [-Wdeprecated-declarations]
     WKPageSetPagePolicyClient(page, &policyClient.base);
                                                       ^
In file included from DerivedSources/ForwardingHeaders/WebKit/WKPage.h:1,
                 from ../../Source/WebKit/UIProcess/API/C/WebKit2_C.h:53,
                 from DerivedSources/ForwardingHeaders/WebKit/WebKit2_C.h:1,
                 from ../../Tools/TestWebKitAPI/config.h:49,
                 from ../../Tools/TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:26:
../../Source/WebKit/UIProcess/API/C/WKPage.h:229:16: note: declared here
 WK_EXPORT void WKPageSetPagePolicyClient(WKPageRef page, const WKPagePolicyClientBase* client) WK_C_API_DEPRECATED_WITH_REPLACEMENT(WKPageSetPageNavigationClient, macosx(WK_MAC_TBA));
                ^~~~~~~~~~~~~~~~~~~~~~~~~
../../Tools/TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:69:55: warning: ‘void WKPageSetPagePolicyClient(WKPageRef, const WKPagePolicyClientBase*)’ is deprecated: use WKPageSetPageNavigationClient [-Wdeprecated-declarations]
     WKPageSetPagePolicyClient(page, &policyClient.base);
                                                       ^
In file included from DerivedSources/ForwardingHeaders/WebKit/WKPage.h:1,
                 from ../../Source/WebKit/UIProcess/API/C/WebKit2_C.h:53,
                 from DerivedSources/ForwardingHeaders/WebKit/WebKit2_C.h:1,
                 from ../../Tools/TestWebKitAPI/config.h:49,
                 from ../../Tools/TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:26:
../../Source/WebKit/UIProcess/API/C/WKPage.h:229:16: note: declared here
 WK_EXPORT void WKPageSetPagePolicyClient(WKPageRef page, const WKPagePolicyClientBase* client) WK_C_API_DEPRECATED_WITH_REPLACEMENT(WKPageSetPageNavigationClient, macosx(WK_MAC_TBA));
                ^~~~~~~~~~~~~~~~~~~~~~~~~
[4649/4761] Building CXX object Tools/TestWebKitAPI...it/ProvisionalURLAfterWillSendRequestCallback.cpp.o
../../Tools/TestWebKitAPI/Tests/WebKit/ProvisionalURLAfterWillSendRequestCallback.cpp: In member function ‘virtual void TestWebKitAPI::WebKit2_ProvisionalURLAfterWillSendRequestCallback_Test::TestBody()’:
../../Tools/TestWebKitAPI/Tests/WebKit/ProvisionalURLAfterWillSendRequestCallback.cpp:80:65: warning: ‘void WKPageSetPageLoaderClient(WKPageRef, const WKPageLoaderClientBase*)’ is deprecated: use WKPageSetPageNavigationClient [-Wdeprecated-declarations]
     WKPageSetPageLoaderClient(webView.page(), &loaderClient.base);
                                                                 ^
In file included from DerivedSources/ForwardingHeaders/WebKit/WKPage.h:1,
                 from ../../Source/WebKit/UIProcess/API/C/WebKit2_C.h:53,
                 from DerivedSources/ForwardingHeaders/WebKit/WebKit2_C.h:1,
                 from ../../Tools/TestWebKitAPI/config.h:49,
                 from ../../Tools/TestWebKitAPI/Tests/WebKit/ProvisionalURLAfterWillSendRequestCallback.cpp:26:
../../Source/WebKit/UIProcess/API/C/WKPage.h:228:16: note: declared here
 WK_EXPORT void WKPageSetPageLoaderClient(WKPageRef page, const WKPageLoaderClientBase* client) WK_C_API_DEPRECATED_WITH_REPLACEMENT(WKPageSetPageNavigationClient, macosx(WK_MAC_TBA));
                ^~~~~~~~~~~~~~~~~~~~~~~~~
../../Tools/TestWebKitAPI/Tests/WebKit/ProvisionalURLAfterWillSendRequestCallback.cpp:80:65: warning: ‘void WKPageSetPageLoaderClient(WKPageRef, const WKPageLoaderClientBase*)’ is deprecated: use WKPageSetPageNavigationClient [-Wdeprecated-declarations]
     WKPageSetPageLoaderClient(webView.page(), &loaderClient.base);
                                                                 ^
In file included from DerivedSources/ForwardingHeaders/WebKit/WKPage.h:1,
                 from ../../Source/WebKit/UIProcess/API/C/WebKit2_C.h:53,
                 from DerivedSources/ForwardingHeaders/WebKit/WebKit2_C.h:1,
                 from ../../Tools/TestWebKitAPI/config.h:49,
                 from ../../Tools/TestWebKitAPI/Tests/WebKit/ProvisionalURLAfterWillSendRequestCallback.cpp:26:
../../Source/WebKit/UIProcess/API/C/WKPage.h:228:16: note: declared here
 WK_EXPORT void WKPageSetPageLoaderClient(WKPageRef page, const WKPageLoaderClientBase* client) WK_C_API_DEPRECATED_WITH_REPLACEMENT(WKPageSetPageNavigationClient, macosx(WK_MAC_TBA));
                ^~~~~~~~~~~~~~~~~~~~~~~~~

[Michael Catanzaro]

These are all in cross-platform tests.

Alex, I guess we should update the tests rather than silencing the warnings.

[Alex Christensen]

Definitely

[Michael Catanzaro]

Created attachment 351515 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 351515 [details]
Patch

Clearing flags on attachment: 351515

Committed r236833: <https://trac.webkit.org/changeset/236833>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/45011949>