Bug 190131 - [JSC] Add a JSONStringify overload that receives a JSValue space
Summary: [JSC] Add a JSONStringify overload that receives a JSValue space
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Blocks: 189947
  Show dependency treegraph
Reported: 2018-10-01 05:52 PDT by Koby
Modified: 2018-10-01 10:28 PDT (History)
8 users (show)

See Also:

Patch (2.44 KB, patch)
2018-10-01 05:55 PDT, Koby
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Koby 2018-10-01 05:52:21 PDT
In node-jsc, I neede to be able to pass a JSValue space to JSONStringify, not just the number of spaces to use.
This patch add that overload to JSONStringify.

Regarding tests, I wasn't sure there are c++ tests to JSONStringify or where should I add them. So for now I didn't add new tests.

Comment 1 Koby 2018-10-01 05:55:43 PDT
Created attachment 351238 [details]
Comment 2 Yusuke Suzuki 2018-10-01 06:55:27 PDT
Comment on attachment 351238 [details]

Comment 3 Yusuke Suzuki 2018-10-01 07:46:35 PDT
Comment on attachment 351238 [details]

BTW, you can request both flags at the same time (r? and cq?).
Comment 4 WebKit Commit Bot 2018-10-01 08:12:32 PDT
Comment on attachment 351238 [details]

Clearing flags on attachment: 351238

Committed r236660: <https://trac.webkit.org/changeset/236660>
Comment 5 WebKit Commit Bot 2018-10-01 08:12:33 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-10-01 08:13:25 PDT
Comment 7 Koby 2018-10-01 10:28:19 PDT
@Yusuke thanks, I thought I had to wait for the review before settings the cq? flag.