RESOLVED FIXED 190125
[MSE][GStreamer] Set a minimum sample duration 
https://bugs.webkit.org/show_bug.cgi?id=190125
Summary [MSE][GStreamer] Set a minimum sample duration
Alicia Boya García
Reported 2018-10-01 04:33:08 PDT
The last sample of the audio track in the asset used in this test player has a tiny duration (100 ns): http://orange-opensource.github.io/hasplayer.js/1.2.0/player.html?url=http://playready.directtaps.net/smoothstreaming/SSWSS720H264/SuperSpeedway_720.ism/Manifest So small, we are truncating it to zero. We're not supposed to have frames with zero duration an. Instead, lets set a minimum frame duration for those fringe cases.
Attachments
Patch (3.00 KB, patch)
2018-10-01 09:21 PDT, Alicia Boya García 		no flags
DetailsFormatted DiffDiff
Patch (3.29 KB, patch)
2018-10-01 10:59 PDT, Alicia Boya García 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alicia Boya García
Comment 1 2018-10-01 09:21:46 PDT
Created attachment 351251 [details] Patch
Xabier Rodríguez Calvar
Comment 2 2018-10-01 10:38:10 PDT
Comment on attachment 351251 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351251&action=review > Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.cpp:59 > + m_duration = createMediaTime(std::max(GST_BUFFER_DURATION(buffer), minimumDuration)); I'd recommend moving this above to a more prominent position than inside this method.
Alicia Boya García
Comment 3 2018-10-01 10:59:43 PDT
Created attachment 351270 [details] Patch
WebKit Commit Bot
Comment 4 2018-10-01 11:38:58 PDT
Comment on attachment 351270 [details] Patch Clearing flags on attachment: 351270 Committed r236679: <https://trac.webkit.org/changeset/236679>
WebKit Commit Bot
Comment 5 2018-10-01 11:39:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.