Bug 190121 – [WTF] r236617 broke JSCOnly build on Windows

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Template Framework

[Koby]

Hi,
After updating my copy of WebKit, the Windows build of JSCOnly port fails with the following error:
c:\togithub\webkit-original\webkit\source\wtf\wtf\generic\mainthreadgeneric.cpp(33): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [C
:\togithub\WebKit-Original\webkit\WebKitBuild\Release\Source\WTF\wtf\WTF.vcxproj]

Looking at the file, it seems that since r236617 MainThreadGeneric.cpp always includes pthread.h, which is a problem since it isn't available on Windows (on the JSCOnly port uses MainThreadGeneric.cpp on all platforms).

What do you think? should this be fixed in MainThreadGeneric or should the JSCOnly use the Windows implementation of MainThread?

Thanks,
Koby

[Yusuke Suzuki]

(In reply to Koby from comment #0)
> Hi,
> After updating my copy of WebKit, the Windows build of JSCOnly port fails
> with the following error:
> c:\togithub\webkit-original\webkit\source\wtf\wtf\generic\mainthreadgeneric.
> cpp(33): fatal error C1083: Cannot open include file: 'pthread.h': No such
> file or directory [C
> :\togithub\WebKit-Original\webkit\WebKitBuild\Release\Source\WTF\wtf\WTF.
> vcxproj]
> 
> Looking at the file, it seems that since r236617 MainThreadGeneric.cpp
> always includes pthread.h, which is a problem since it isn't available on
> Windows (on the JSCOnly port uses MainThreadGeneric.cpp on all platforms).
> 
> What do you think? should this be fixed in MainThreadGeneric or should the
> JSCOnly use the Windows implementation of MainThread?
> 
> Thanks,
> Koby

Use MainThreadWin instead in Window.

[Koby]

Thanks! it seems to compile. I'll test it and upload a patch here.
If I'm moving MainThread to the Windows implementation, is there anything else I need to change? Like the WorkQueueGeneric which is currently used (vs WorkQueueWin)?

[Yusuke Suzuki]

(In reply to Koby from comment #2)
> Thanks! it seems to compile. I'll test it and upload a patch here.
> If I'm moving MainThread to the Windows implementation, is there anything
> else I need to change? Like the WorkQueueGeneric which is currently used (vs
> WorkQueueWin)?

Just using MainThreadWin.cpp instead of MainThreadGeneric.cpp is OK. It should work.

[Koby]

Created attachment 351236 [details]
Patch

[Koby]

Added a patch :)

[Yusuke Suzuki]

Comment on attachment 351236 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 351236 [details]
Patch

Clearing flags on attachment: 351236

Committed r236655: <https://trac.webkit.org/changeset/236655>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/44906628>