RESOLVED FIXED 190118
'HAVE_PTHREAD_MAIN_NP' macro redefined warning when building --jsc-only on macOS 
https://bugs.webkit.org/show_bug.cgi?id=190118
Summary 'HAVE_PTHREAD_MAIN_NP' macro redefined warning when building --jsc-only on macOS
Caio Lima
Reported 2018-09-30 10:13:40 PDT
Here is the warning when compiling --jsc-only on macOS: In file included from /webkit/Source/JavaScriptCore/API/tests/testapi.c:27: In file included from /webkit/Source/JavaScriptCore/config.h:31: In file included from /webkit/Source/JavaScriptCore/runtime/JSExportMacros.h:32: In file included from /webkit/WebKitBaselineBuild/Release/DerivedSources/ForwardingHeaders/wtf/ExportMacros.h:32: /webkit/WebKitBaselineBuild/Release/DerivedSources/ForwardingHeaders/wtf/Platform.h:658:9: warning: 'HAVE_PTHREAD_MAIN_NP' macro redefined [-Wmacro-redefined] #define HAVE_PTHREAD_MAIN_NP 1 ^ /webkit/WebKitBaselineBuild/Release/cmakeconfig.h:128:9: note: previous definition is here #define HAVE_PTHREAD_MAIN_NP 0
Attachments
Patch (1.45 KB, patch)
2018-09-30 10:25 PDT, Caio Lima 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Caio Lima
Comment 1 2018-09-30 10:25:50 PDT
Created attachment 351215 [details] Patch
Yusuke Suzuki
Comment 2 2018-10-01 03:12:51 PDT
Comment on attachment 351215 [details] Patch r=me
Caio Lima
Comment 3 2018-10-01 04:30:30 PDT
Comment on attachment 351215 [details] Patch Thx for the review
WebKit Commit Bot
Comment 4 2018-10-01 04:56:29 PDT
Comment on attachment 351215 [details] Patch Clearing flags on attachment: 351215 Committed r236654: <https://trac.webkit.org/changeset/236654>
WebKit Commit Bot
Comment 5 2018-10-01 04:56:31 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-10-01 04:57:26 PDT
<rdar://problem/44906284>
Note You need to log in before you can comment on or make changes to this bug.