Bug 190118 - 'HAVE_PTHREAD_MAIN_NP' macro redefined warning when building --jsc-only on macOS
Summary: 'HAVE_PTHREAD_MAIN_NP' macro redefined warning when building --jsc-only on macOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Caio Lima
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-30 10:13 PDT by Caio Lima
Modified: 2018-10-01 04:57 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.45 KB, patch)
2018-09-30 10:25 PDT, Caio Lima 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Caio Lima 2018-09-30 10:13:40 PDT 
Here is the warning when compiling --jsc-only on macOS:

In file included from /webkit/Source/JavaScriptCore/API/tests/testapi.c:27:
In file included from /webkit/Source/JavaScriptCore/config.h:31:
In file included from /webkit/Source/JavaScriptCore/runtime/JSExportMacros.h:32:
In file included from /webkit/WebKitBaselineBuild/Release/DerivedSources/ForwardingHeaders/wtf/ExportMacros.h:32:
/webkit/WebKitBaselineBuild/Release/DerivedSources/ForwardingHeaders/wtf/Platform.h:658:9: warning: 'HAVE_PTHREAD_MAIN_NP' macro redefined [-Wmacro-redefined]
#define HAVE_PTHREAD_MAIN_NP 1
        ^
/webkit/WebKitBaselineBuild/Release/cmakeconfig.h:128:9: note: previous definition is here
#define HAVE_PTHREAD_MAIN_NP 0
Comment 1 Caio Lima 2018-09-30 10:25:50 PDT 
Created attachment 351215 [details]
Patch
Comment 2 Yusuke Suzuki 2018-10-01 03:12:51 PDT 
Comment on attachment 351215 [details]
Patch

r=me
Comment 3 Caio Lima 2018-10-01 04:30:30 PDT 
Comment on attachment 351215 [details]
Patch

Thx for the review
Comment 4 WebKit Commit Bot 2018-10-01 04:56:29 PDT 
Comment on attachment 351215 [details]
Patch

Clearing flags on attachment: 351215

Committed r236654: <https://trac.webkit.org/changeset/236654>
Comment 5 WebKit Commit Bot 2018-10-01 04:56:31 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-10-01 04:57:26 PDT 
<rdar://problem/44906284>