190111 – URL should not use TextEncoding internally

RESOLVED FIXED 190111

URL should not use TextEncoding internally

https://bugs.webkit.org/show_bug.cgi?id=190111

Summary URL should not use TextEncoding internally

Alex Christensen

Reported 2018-09-29 09:33:26 PDT

URL should not use TextEncoding internally

Attachments
Patch (12.90 KB, patch) 2018-09-29 09:38 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (13.42 KB, patch) 2018-09-29 09:48 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (14.50 KB, patch) 2018-09-29 09:56 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-sierra (2.35 MB, application/zip) 2018-09-29 11:07 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (2.98 MB, application/zip) 2018-09-29 11:22 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews114 for mac-sierra (3.03 MB, application/zip) 2018-09-29 12:02 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews117 for mac-sierra (3.03 MB, application/zip) 2018-09-29 14:03 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.41 MB, application/zip) 2018-09-29 14:14 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (2.40 MB, application/zip) 2018-09-29 17:01 PDT, EWS Watchlist	no flags	Details
Patch (14.98 KB, patch) 2018-09-29 22:56 PDT, Alex Christensen	aestes: review+	Details Formatted Diff Diff
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2018-09-29 09:38:13 PDT

Created attachment 351183 [details] Patch

Alex Christensen

Comment 2 2018-09-29 09:48:44 PDT

Created attachment 351184 [details] Patch

Alex Christensen

Comment 3 2018-09-29 09:56:31 PDT

Created attachment 351185 [details] Patch

EWS Watchlist

Comment 4 2018-09-29 09:58:23 PDT

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

EWS Watchlist

Comment 5 2018-09-29 11:06:59 PDT

Comment on attachment 351185 [details] Patch Attachment 351185 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9395105 New failing tests: http/tests/xmlhttprequest/basic-auth-nouser.html

EWS Watchlist

Comment 6 2018-09-29 11:07:01 PDT

Created attachment 351187 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 7 2018-09-29 11:22:03 PDT

Comment on attachment 351185 [details] Patch Attachment 351185 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9395136 New failing tests: http/tests/xmlhttprequest/basic-auth-nouser.html

EWS Watchlist

Comment 8 2018-09-29 11:22:05 PDT

Created attachment 351190 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Daniel Bates

Comment 9 2018-09-29 11:45:17 PDT

Comment on attachment 351185 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351185&action=review > Source/WebCore/ChangeLog:8 > + That dependency makes it impossible to move or use elsewhere. Where do you want to use URL that TextEncoding is causing a problem? Can you please elaborate?

EWS Watchlist

Comment 10 2018-09-29 12:02:44 PDT

Comment on attachment 351185 [details] Patch Attachment 351185 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9395195 New failing tests: http/tests/xmlhttprequest/basic-auth-nouser.html

EWS Watchlist

Comment 11 2018-09-29 12:02:45 PDT

Created attachment 351193 [details] Archive of layout-test-results from ews114 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 12 2018-09-29 14:03:41 PDT

Comment on attachment 351185 [details] Patch Attachment 351185 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9395953 New failing tests: http/tests/xmlhttprequest/basic-auth-nouser.html

EWS Watchlist

Comment 13 2018-09-29 14:03:43 PDT

Created attachment 351196 [details] Archive of layout-test-results from ews117 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 14 2018-09-29 14:13:58 PDT

Comment on attachment 351185 [details] Patch Attachment 351185 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9395947 New failing tests: http/tests/xmlhttprequest/basic-auth-nouser.html

EWS Watchlist

Comment 15 2018-09-29 14:14:00 PDT

Created attachment 351197 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 16 2018-09-29 17:01:50 PDT

Comment on attachment 351185 [details] Patch Attachment 351185 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9396770 New failing tests: http/tests/xmlhttprequest/basic-auth-nouser.html

EWS Watchlist

Comment 17 2018-09-29 17:01:52 PDT

Created attachment 351202 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

Alex Christensen

Comment 18 2018-09-29 22:56:32 PDT

Created attachment 351210 [details] Patch

Alex Christensen

Comment 19 2018-09-29 23:06:34 PDT

(In reply to Daniel Bates from comment #9) > Comment on attachment 351185 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=351185&action=review > > > Source/WebCore/ChangeLog:8 > > + That dependency makes it impossible to move or use elsewhere. > > > Where do you want to use URL that TextEncoding is causing a problem? Can you > please elaborate? See rdar://problem/44119696

Alex Christensen

Comment 20 2018-10-01 11:16:47 PDT

http://trac.webkit.org/r236674

Radar WebKit Bug Importer

Comment 21 2018-10-01 11:17:30 PDT

<rdar://problem/44914697>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component New Bugs

Assignee

Alex Christensen

Reported

2018-09-29 09:33 PDT

Modified

2018-10-01 11:17 PDT History

CC List

10 users Show

URL

Keywords InRadar

Depends on

Blocks