URL should not use TextEncoding internally
Created attachment 351183 [details] Patch
Created attachment 351184 [details] Patch
Created attachment 351185 [details] Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment on attachment 351185 [details] Patch Attachment 351185 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9395105 New failing tests: http/tests/xmlhttprequest/basic-auth-nouser.html
Created attachment 351187 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 351185 [details] Patch Attachment 351185 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9395136 New failing tests: http/tests/xmlhttprequest/basic-auth-nouser.html
Created attachment 351190 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 351185 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351185&action=review > Source/WebCore/ChangeLog:8 > + That dependency makes it impossible to move or use elsewhere. Where do you want to use URL that TextEncoding is causing a problem? Can you please elaborate?
Comment on attachment 351185 [details] Patch Attachment 351185 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9395195 New failing tests: http/tests/xmlhttprequest/basic-auth-nouser.html
Created attachment 351193 [details] Archive of layout-test-results from ews114 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 351185 [details] Patch Attachment 351185 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9395953 New failing tests: http/tests/xmlhttprequest/basic-auth-nouser.html
Created attachment 351196 [details] Archive of layout-test-results from ews117 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 351185 [details] Patch Attachment 351185 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9395947 New failing tests: http/tests/xmlhttprequest/basic-auth-nouser.html
Created attachment 351197 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 351185 [details] Patch Attachment 351185 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9396770 New failing tests: http/tests/xmlhttprequest/basic-auth-nouser.html
Created attachment 351202 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Created attachment 351210 [details] Patch
(In reply to Daniel Bates from comment #9) > Comment on attachment 351185 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=351185&action=review > > > Source/WebCore/ChangeLog:8 > > + That dependency makes it impossible to move or use elsewhere. > > > Where do you want to use URL that TextEncoding is causing a problem? Can you > please elaborate? See rdar://problem/44119696
http://trac.webkit.org/r236674
<rdar://problem/44914697>