190104 – Optimize RenderStyle::diff() and clean up the code

RESOLVED FIXED 190104

Optimize RenderStyle::diff() and clean up the code

https://bugs.webkit.org/show_bug.cgi?id=190104

Summary Optimize RenderStyle::diff() and clean up the code

Simon Fraser (smfr)

Reported 2018-09-28 18:15:56 PDT

Optimize RenderStyle::diff() and clean up the code

Attachments
Patch (27.69 KB, patch) 2018-09-28 18:22 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (29.91 KB, patch) 2018-09-28 21:12 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-sierra (2.36 MB, application/zip) 2018-09-28 22:15 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (2.99 MB, application/zip) 2018-09-28 22:26 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews201 for win-future (13.22 MB, application/zip) 2018-09-28 22:50 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews115 for mac-sierra (3.08 MB, application/zip) 2018-09-28 23:08 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.64 MB, application/zip) 2018-09-29 02:10 PDT, EWS Watchlist	no flags	Details
Patch (30.01 KB, patch) 2018-09-29 08:28 PDT, Simon Fraser (smfr)	mitz: review+ ews-watchlist: commit-queue-	Details Formatted Diff Diff
RenderStyle.cpp for ease of review (90.72 KB, text/plain) 2018-09-29 08:31 PDT, Simon Fraser (smfr)	no flags	Details
Archive of layout-test-results from ews203 for win-future (13.15 MB, application/zip) 2018-09-29 11:57 PDT, EWS Watchlist	no flags	Details
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2018-09-28 18:22:41 PDT

Created attachment 351154 [details] Patch

Simon Fraser (smfr)

Comment 2 2018-09-28 21:12:37 PDT

Created attachment 351166 [details] Patch

alan

Comment 3 2018-09-28 21:15:49 PDT

>Optimize RenderStyle::diff() and clean up the code Do you mind splitting it into multiple patches? I find it difficult to review this (unless someone else is willing to r+it as it is)

EWS Watchlist

Comment 4 2018-09-28 22:15:54 PDT Comment hidden (obsolete)

Comment on attachment 351166 [details] Patch Attachment 351166 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9390801 New failing tests: fast/table/correct-baseline-after-style-change.html

EWS Watchlist

Comment 5 2018-09-28 22:15:56 PDT Comment hidden (obsolete)

Created attachment 351170 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 6 2018-09-28 22:26:35 PDT Comment hidden (obsolete)

Comment on attachment 351166 [details] Patch Attachment 351166 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9390812 New failing tests: fast/table/correct-baseline-after-style-change.html

EWS Watchlist

Comment 7 2018-09-28 22:26:37 PDT Comment hidden (obsolete)

Created attachment 351171 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 8 2018-09-28 22:50:37 PDT Comment hidden (obsolete)

Comment on attachment 351166 [details] Patch Attachment 351166 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/9390916 New failing tests: fast/table/correct-baseline-after-style-change.html

EWS Watchlist

Comment 9 2018-09-28 22:50:49 PDT Comment hidden (obsolete)

Created attachment 351172 [details] Archive of layout-test-results from ews201 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews201 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit

EWS Watchlist

Comment 10 2018-09-28 23:08:32 PDT Comment hidden (obsolete)

Comment on attachment 351166 [details] Patch Attachment 351166 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9390878 New failing tests: fast/table/correct-baseline-after-style-change.html

EWS Watchlist

Comment 11 2018-09-28 23:08:34 PDT Comment hidden (obsolete)

Created attachment 351173 [details] Archive of layout-test-results from ews115 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 12 2018-09-29 02:10:00 PDT Comment hidden (obsolete)

Comment on attachment 351166 [details] Patch Attachment 351166 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9391705 New failing tests: fast/table/correct-baseline-after-style-change.html

EWS Watchlist

Comment 13 2018-09-29 02:10:02 PDT Comment hidden (obsolete)

Created attachment 351176 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

Simon Fraser (smfr)

Comment 14 2018-09-29 08:28:50 PDT

Created attachment 351180 [details] Patch

Simon Fraser (smfr)

Comment 15 2018-09-29 08:31:06 PDT

Created attachment 351181 [details] RenderStyle.cpp for ease of review

EWS Watchlist

Comment 16 2018-09-29 11:57:36 PDT

Comment on attachment 351180 [details] Patch Attachment 351180 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/9395204 New failing tests: fast/workers/worker-exception-during-navigation.html

EWS Watchlist

Comment 17 2018-09-29 11:57:51 PDT

Created attachment 351192 [details] Archive of layout-test-results from ews203 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews203 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

mitz

Comment 18 2018-09-29 14:16:19 PDT

Comment on attachment 351180 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351180&action=review > Source/WebCore/ChangeLog:10 > + To reduce the changes of future changes regressing this, move code comparing values the chances

Simon Fraser (smfr)

Comment 19 2018-10-01 13:41:02 PDT

https://trac.webkit.org/changeset/236677/webkit

Radar WebKit Bug Importer

Comment 20 2018-10-01 13:41:42 PDT

<rdar://problem/44919499>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component New Bugs

Assignee

Simon Fraser (smfr)

Reported

2018-09-28 18:15 PDT

Modified

2018-10-01 13:41 PDT History

CC List

7 users Show

URL

Keywords InRadar

Depends on

Blocks