Bug 190100 – Web Inspector: Table with no selection should select the first/last row on down/up arrow key

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Matt Baker]

Summary:
Table with no selected row should select the first/last row on down/up arrow key.

This improves behavior parity with macOS tables (Finder, Instruments, AppKit's NSTableView, etc).

Steps to Reproduce:
1. Open Network tab
2. Focus the table without selecting a row (click past the last row)
3. Press down (or up) arrow key
Actual:
  => Nothing happens
Expected:
  => First (or last) row is selected

[Radar WebKit Bug Importer]

<rdar://problem/44879243>

[Matt Baker]

Created attachment 351147 [details]
WIP

[Matt Baker]

(In reply to Matt Baker from comment #2)
> Created attachment 351147 [details]
> WIP

Lacks support for when the first or last row is not in the cache.

[Matt Baker]

Created attachment 354264 [details]
Patch

[Matt Baker]

Created attachment 354672 [details]
Patch

[Devin Rousso]

Comment on attachment 354672 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354672&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/Table.js:454
> +        this.needsLayout();

If we wait for a layout rAF, we'll end up flashing content as we will scroll before the new content is visible.  I think this should be `updateLayout` if the row isn't currently visible, but it can stay as is for rows that are.

> Source/WebInspectorUI/UserInterface/Views/Table.js:1304
> +        if (event.metaKey || event.ctrlKey)
>              return;

Duplicate of next line.  Please remove.

[Matt Baker]

Created attachment 354682 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 354682 [details]
Patch for landing

Clearing flags on attachment: 354682

Committed r238139: <https://trac.webkit.org/changeset/238139>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.