Bug 190095 - REGRESSION(r236609): API tests for mso list preservation are failing
Summary: REGRESSION(r236609): API tests for mso list preservation are failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-28 15:18 PDT by Ryosuke Niwa
Modified: 2018-09-28 15:32 PDT (History)
2 users (show)

See Also:


Attachments
Fixes the bug (1.71 KB, patch)
2018-09-28 15:26 PDT, Ryosuke Niwa
wenson_hsieh: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2018-09-28 15:18:58 PDT
e.g.
https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK1%20%28Tests%29/builds/8288/steps/run-api-tests/logs/stdio


TestWebKitAPI.PasteWebArchive.ExposesHTMLTypeInDataTransfer Passed

    
    /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteWebArchive.mm:123
    Value of: [webView stringByEvaluatingJavaScript:@"pastedHTML.includes('<style class=\"WebKit-mso-list-quirks-style\">\\n<!--\\n')"].boolValue
      Actual: false
    Expected: true

...
 
    /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteWebArchive.mm:144
    Value of: [webView stringByEvaluatingJavaScript:@"htmlInDataTransfer.includes('[endif]')"].boolValue
      Actual: false
    Expected: true
    
TestWebKitAPI.PasteWebArchive.PreservesMSOList Failed

    
    /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteWebArchive.mm:174
    Value of: [webView stringByEvaluatingJavaScript:@"pastedHTML.includes('<style class=\"WebKit-mso-list-quirks-style\">\\n<!--\\n')"].boolValue
      Actual: false
    Expected: true

...

    /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteWebArchive.mm:191
    Value of: [webView stringByEvaluatingJavaScript:@"htmlInDataTransfer.includes('[endif]')"].boolValue
      Actual: false
    Expected: true
    
TestWebKitAPI.PasteWebArchive.PreservesMSOListInCompatibilityMode Failed
Comment 1 Radar WebKit Bug Importer 2018-09-28 15:25:17 PDT
<rdar://problem/44876754>
Comment 2 Ryosuke Niwa 2018-09-28 15:26:45 PDT
Created attachment 351119 [details]
Fixes the bug
Comment 3 Ryosuke Niwa 2018-09-28 15:32:58 PDT
Committed r236618: <https://trac.webkit.org/changeset/236618>