WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
190090
The return value of an OnBeforeUnloadEventHandler should always be coerced into a DOMString
https://bugs.webkit.org/show_bug.cgi?id=190090
Summary
The return value of an OnBeforeUnloadEventHandler should always be coerced in...
Chris Dumez
Reported
2018-09-28 14:13:09 PDT
The return value of an OnBeforeUnloadEventHandler should always be coerced into a DOMString: -
https://html.spec.whatwg.org/#onbeforeunloadeventhandler
-
https://html.spec.whatwg.org/#the-event-handler-processing-algorithm
In particular, this means that returning false in an OnBeforeUnloadEventHandler should NOT cancel the event when the event is a CustomEvent (and not a BeforeUnloadEvent). This is because the return value cannot be false at: -
https://html.spec.whatwg.org/#the-event-handler-processing-algorithm
(Step 5. Otherwise case).
Attachments
Patch
(10.87 KB, patch)
2018-09-28 14:27 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2018-09-28 14:27:45 PDT
Created
attachment 351110
[details]
Patch
WebKit Commit Bot
Comment 2
2018-09-28 19:04:00 PDT
Comment on
attachment 351110
[details]
Patch Clearing flags on attachment: 351110 Committed
r236633
: <
https://trac.webkit.org/changeset/236633
>
WebKit Commit Bot
Comment 3
2018-09-28 19:04:01 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug