Bug 190077 - Drop iOS specific quirk in SettingsBase::scriptEnabledChanged()
Summary: Drop iOS specific quirk in SettingsBase::scriptEnabledChanged()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-28 09:26 PDT by Chris Dumez
Modified: 2018-09-28 10:04 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.89 KB, patch)
2018-09-28 09:29 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-09-28 09:26:13 PDT
Drop iOS specific quirk in SettingsBase::scriptEnabledChanged()
Comment 1 Chris Dumez 2018-09-28 09:26:29 PDT
<rdar://problem/44812613>
Comment 2 Chris Dumez 2018-09-28 09:29:43 PDT
Created attachment 351084 [details]
Patch
Comment 3 Simon Fraser (smfr) 2018-09-28 09:58:21 PDT
Comment on attachment 351084 [details]
Patch

Did we look at internal SVN history to see why this was added?
Comment 4 Chris Dumez 2018-09-28 10:01:33 PDT
(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 351084 [details]
> Patch
> 
> Did we look at internal SVN history to see why this was added?

I haven't because I did not know this was a thing. I tried to git blame and did not find anything useful.
Comment 5 WebKit Commit Bot 2018-09-28 10:04:12 PDT
Comment on attachment 351084 [details]
Patch

Clearing flags on attachment: 351084

Committed r236600: <https://trac.webkit.org/changeset/236600>
Comment 6 WebKit Commit Bot 2018-09-28 10:04:13 PDT
All reviewed patches have been landed.  Closing bug.