Bug 190069 - Replace every use of Node::offsetInCharacters() by Node::isCharacterDataNode()
Summary: Replace every use of Node::offsetInCharacters() by Node::isCharacterDataNode()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-27 21:39 PDT by Ryosuke Niwa
Modified: 2018-09-28 12:48 PDT (History)
7 users (show)

See Also:

Attachments
Cleanup (13.82 KB, patch)
2018-09-27 21:45 PDT, Ryosuke Niwa 		zalan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2018-09-27 21:39:48 PDT 
The implementation of Node::offsetInCharacters() is identical to Node::isCharacterDataNode().

It's super confusing because offsetInCharacters() sounds like a function
which returns the number of characters in the node, or some kind of an offset within the characters.
Comment 1 Ryosuke Niwa 2018-09-27 21:45:19 PDT 
Created attachment 351052 [details]
Cleanup
Comment 2 Ryosuke Niwa 2018-09-28 12:47:25 PDT 
Committed r236607: <https://trac.webkit.org/changeset/236607>
Comment 3 Radar WebKit Bug Importer 2018-09-28 12:48:31 PDT 
<rdar://problem/44872083>