RESOLVED FIXED 190069
Replace every use of Node::offsetInCharacters() by Node::isCharacterDataNode() 
https://bugs.webkit.org/show_bug.cgi?id=190069
Summary Replace every use of Node::offsetInCharacters() by Node::isCharacterDataNode()
Ryosuke Niwa
Reported 2018-09-27 21:39:48 PDT
The implementation of Node::offsetInCharacters() is identical to Node::isCharacterDataNode(). It's super confusing because offsetInCharacters() sounds like a function which returns the number of characters in the node, or some kind of an offset within the characters.
Attachments
Cleanup (13.82 KB, patch)
2018-09-27 21:45 PDT, Ryosuke Niwa 		zalan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2018-09-27 21:45:19 PDT
Created attachment 351052 [details] Cleanup
Ryosuke Niwa
Comment 2 2018-09-28 12:47:25 PDT
Committed r236607: <https://trac.webkit.org/changeset/236607>
Radar WebKit Bug Importer
Comment 3 2018-09-28 12:48:31 PDT
<rdar://problem/44872083>
Note You need to log in before you can comment on or make changes to this bug.