Bug 190064 - Don't use int offsets in StructureStubInfo
Summary: Don't use int offsets in StructureStubInfo
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-27 17:53 PDT by Saam Barati
Modified: 2018-09-27 21:27 PDT (History)
11 users (show)

See Also:

Attachments
patch (5.66 KB, patch)
2018-09-27 18:51 PDT, Saam Barati 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2018-09-27 17:53:16 PDT 
...
Comment 1 Saam Barati 2018-09-27 17:54:16 PDT 
<rdar://problem/44784719>
Comment 2 Saam Barati 2018-09-27 18:51:38 PDT 
Created attachment 351036 [details]
patch
Comment 3 Mark Lam 2018-09-27 21:05:14 PDT 
Comment on attachment 351036 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351036&action=review

r=me.

> Source/JavaScriptCore/bytecode/StructureStubInfo.h:189
>          RegisterSet usedRegisters;

I suggest moving this after the CodeLocations for better packing of this struct.  It was well packed before with the trailing 32-bit ints.  It won't be anymore with the 64-bit CodeLocations, unless we move it after.
Comment 4 Saam Barati 2018-09-27 21:27:32 PDT 
landed in:
https://trac.webkit.org/changeset/236584/webkit