Bug 190049 - [Payment Request] Update web platform tests
Summary: [Payment Request] Update web platform tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-27 12:47 PDT by Andy Estes
Modified: 2018-09-27 14:06 PDT (History)
13 users (show)

See Also:


Attachments
Patch (32.35 KB, patch)
2018-09-27 12:52 PDT, Andy Estes
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2018-09-27 12:47:25 PDT
[Payment Request] Update web platform tests
Comment 1 Andy Estes 2018-09-27 12:52:18 PDT
Created attachment 350988 [details]
Patch
Comment 2 youenn fablet 2018-09-27 13:12:15 PDT
Comment on attachment 350988 [details]
Patch

r=me once bots are green.

View in context: https://bugs.webkit.org/attachment.cgi?id=350988&action=review

> LayoutTests/platform/mac-wk2/TestExpectations:863
> +imported/w3c/web-platform-tests/payment-request/payment-response/onpayerdetailchange-attribute-manual.https.html [ Skip ]

The importer should by default not import manual tests.
Do we need these in WebKit repo?
Comment 3 Andy Estes 2018-09-27 13:18:11 PDT
(In reply to youenn fablet from comment #2)
> Comment on attachment 350988 [details]
> Patch
> 
> r=me once bots are green.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=350988&action=review
> 
> > LayoutTests/platform/mac-wk2/TestExpectations:863
> > +imported/w3c/web-platform-tests/payment-request/payment-response/onpayerdetailchange-attribute-manual.https.html [ Skip ]
> 
> The importer should by default not import manual tests.
> Do we need these in WebKit repo?

I feel like I must be doing something wrong, because the importer has been importing manual tests even though I don't specify -a. Maybe the payment-request manual tests don't match the naming format expected by the importer?

That said, the manual tests are kinda helpful. Some of them I've converted to automated tests using internals.mockPaymentCoordinator (in http/tests/paymentrequest).
Comment 4 youenn fablet 2018-09-27 13:19:57 PDT
> I feel like I must be doing something wrong, because the importer has been
> importing manual tests even though I don't specify -a. Maybe the
> payment-request manual tests don't match the naming format expected by the
> importer?

Or maybe we regressed the importer!

> That said, the manual tests are kinda helpful. Some of them I've converted
> to automated tests using internals.mockPaymentCoordinator (in
> http/tests/paymentrequest).

It seems sad that we could not share these internal-based tests in WPT since probably other browsers do something similar. Might be something we should push for upstream.
Comment 5 Andy Estes 2018-09-27 13:41:05 PDT
(In reply to youenn fablet from comment #4)
> > I feel like I must be doing something wrong, because the importer has been
> > importing manual tests even though I don't specify -a. Maybe the
> > payment-request manual tests don't match the naming format expected by the
> > importer?
> 
> Or maybe we regressed the importer!

I'll investigate.

> 
> > That said, the manual tests are kinda helpful. Some of them I've converted
> > to automated tests using internals.mockPaymentCoordinator (in
> > http/tests/paymentrequest).
> 
> It seems sad that we could not share these internal-based tests in WPT since
> probably other browsers do something similar. Might be something we should
> push for upstream.

Yeah, we can do better here. I think this would be a good thing to talk about with the Web Payments WG at TPAC.
Comment 6 WebKit Commit Bot 2018-09-27 14:05:09 PDT
Comment on attachment 350988 [details]
Patch

Clearing flags on attachment: 350988

Committed r236570: <https://trac.webkit.org/changeset/236570>
Comment 7 WebKit Commit Bot 2018-09-27 14:05:10 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-09-27 14:06:26 PDT
<rdar://problem/44843036>