Bug 190034 – Remove the frames() timing function

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Antoine Quint]

We implemented the new frames() timing function as part of the work on Web Animations, but that function has been removed and its functionality are now available via the steps() timing function and the jump-* keywords. We need to make this change and place this new functionality behind a flag that would be disabled while the spec is under development.

[Radar WebKit Bug Importer]

<rdar://problem/44827544>

[Antoine Quint]

For reference, this is the relevant spec:

https://www.w3.org/TR/css-timing-1/#step-timing-functions

[Antoine Quint]

We'll use this bug to remove frames() and use webkit.org/b/190406 to track the implementation of the jump-* values for steps().

[Antoine Quint]

Created attachment 351899 [details]
Patch

[Dean Jackson]

Comment on attachment 351899 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351899&action=review

> Source/WebCore/ChangeLog:9
> +        No new tests (OOPS!).

OOPS!

> LayoutTests/imported/w3c/ChangeLog:13
> +        * web-platform-tests/css-timing-1/frames-timing-functions-output-expected.txt:
> +        * web-platform-tests/css-timing-1/frames-timing-functions-syntax-expected.txt:
> +        * web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-transformed-distance-expected.txt:
> +        * web-platform-tests/web-animations/interfaces/AnimationEffectTiming/easing-expected.txt:
> +        * web-platform-tests/web-animations/timing-model/time-transformations/transformed-progress-expected.txt:

You should contribute these back to WPT.

[EWS Watchlist]

Attachment 351899 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:9:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Antoine Quint]

Created attachment 351904 [details]
Patch

[Antoine Quint]

Created attachment 351915 [details]
Patch

[EWS Watchlist]

Comment on attachment 351915 [details]
Patch

Attachment 351915 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9508399

New failing tests:
legacy-animation-engine/transitions/transitions-parsing.html
legacy-animation-engine/transitions/frames-timing-function.html

[EWS Watchlist]

Created attachment 351919 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 351915 [details]
Patch

Attachment 351915 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9508661

New failing tests:
legacy-animation-engine/transitions/transitions-parsing.html
legacy-animation-engine/transitions/frames-timing-function.html

[EWS Watchlist]

Created attachment 351923 [details]
Archive of layout-test-results from ews112 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 351915 [details]
Patch

Attachment 351915 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9509595

New failing tests:
legacy-animation-engine/transitions/transitions-parsing.html
legacy-animation-engine/transitions/frames-timing-function.html

[EWS Watchlist]

Created attachment 351930 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 351915 [details]
Patch

Attachment 351915 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9509407

New failing tests:
legacy-animation-engine/transitions/transitions-parsing.html
legacy-animation-engine/transitions/frames-timing-function.html

[EWS Watchlist]

Created attachment 351933 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 351915 [details]
Patch

Attachment 351915 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9510422

New failing tests:
legacy-animation-engine/transitions/transitions-parsing.html
legacy-animation-engine/transitions/frames-timing-function.html

[EWS Watchlist]

Created attachment 351940 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Antoine Quint]

Committed r236998: <https://trac.webkit.org/changeset/236998>

[Alex Christensen]

Comment on attachment 351915 [details]
Patch

This has been requesting review for more than one year.  If this is still needed, please rebase and re-request review.