Bug 190019 - [iOS] Allow access to VoiceServices features needed for accessibility
Summary: [iOS] Allow access to VoiceServices features needed for accessibility
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on: 181619
Blocks:
  Show dependency tree / graph
 
Reported: 2018-09-26 17:15 PDT by Brent Fulgham
Modified: 2018-09-27 14:28 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.06 KB, patch)
2018-09-26 17:19 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (1.50 KB, patch)
2018-09-27 12:10 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2018-09-26 17:15:38 PDT 
I tightened the sandbox too far in Bug 181619, causing some non-US English voice WebSpeech features to stop working.

This patch expands the sandbox to allow those features to work properly in iOS 12.
Comment 1 Brent Fulgham 2018-09-26 17:17:58 PDT 
<rdar://problem/43621111>
Comment 2 Brent Fulgham 2018-09-26 17:19:53 PDT 
Created attachment 350928 [details]
Patch
Comment 3 chris fleizach 2018-09-26 17:26:37 PDT 
Comment on attachment 350928 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350928&action=review

> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:99
> +    (global-name "com.apple.voiceservices.keepalive") ; Needed for non-US english language synthesis

suspect these are not technically needed.
Comment 4 Per Arne Vollan 2018-09-27 11:57:23 PDT 
(In reply to chris fleizach from comment #3)
> Comment on attachment 350928 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=350928&action=review
> 
> > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:99
> > +    (global-name "com.apple.voiceservices.keepalive") ; Needed for non-US english language synthesis
> 
> suspect these are not technically needed.

I will remove these.
Comment 5 Per Arne Vollan 2018-09-27 12:10:54 PDT 
Created attachment 350984 [details]
Patch
Comment 6 Per Arne Vollan 2018-09-27 13:45:09 PDT 
Comment on attachment 350984 [details]
Patch

Thanks for reviewing!
Comment 7 WebKit Commit Bot 2018-09-27 14:28:00 PDT 
Comment on attachment 350984 [details]
Patch

Clearing flags on attachment: 350984

Committed r236571: <https://trac.webkit.org/changeset/236571>
Comment 8 WebKit Commit Bot 2018-09-27 14:28:02 PDT 
All reviewed patches have been landed.  Closing bug.