Bug 190010 - Split NaN-check into separate test
Summary: Split NaN-check into separate test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-26 14:01 PDT by Dominik Inführ
Modified: 2018-10-01 12:41 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.26 KB, patch)
2018-09-26 14:05 PDT, Dominik Inführ 		no flags Details | Formatted Diff | Diff
Patch (3.23 KB, patch)
2018-09-27 02:21 PDT, Dominik Inführ 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews113 for mac-sierra (3.06 MB, application/zip)
2018-09-27 04:18 PDT, EWS Watchlist 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dominik Inführ 2018-09-26 14:01:34 PDT 
Split NaN-check into separate test
Comment 1 Dominik Inführ 2018-09-26 14:05:55 PDT 
Created attachment 350900 [details]
Patch
Comment 2 Saam Barati 2018-09-26 18:19:43 PDT 
Comment on attachment 350900 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350900&action=review

> JSTests/ChangeLog:9
> +        DataView exposes NaN-representation, which is not necessarily the same on each
> +        architecture. Therefore move the check of the NaN-representation into its own
> +        file such that we can disable this test on MIPS where NaN-representation can be
> +        different on older CPUs.

nit: Please move this underneath the "Reviewed by"
Comment 3 Dominik Inführ 2018-09-27 02:21:16 PDT 
Created attachment 350954 [details]
Patch
Comment 4 Dominik Inführ 2018-09-27 02:28:31 PDT 
Thank you very much for the review! I've updated the ChangeLog.
Comment 5 EWS Watchlist 2018-09-27 04:18:42 PDT 
Comment on attachment 350954 [details]
Patch

Attachment 350954 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9366830

New failing tests:
storage/indexeddb/cursor-update.html
Comment 6 EWS Watchlist 2018-09-27 04:18:43 PDT 
Created attachment 350955 [details]
Archive of layout-test-results from ews113 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 7 Michael Catanzaro 2018-10-01 12:14:35 PDT 
(In reply to Build Bot from comment #5)
> Comment on attachment 350954 [details]
> Patch
> 
> Attachment 350954 [details] did not pass mac-debug-ews (mac):
> Output: https://webkit-queues.webkit.org/results/9366830
> 
> New failing tests:
> storage/indexeddb/cursor-update.html

This test has been flaky for years. Really needs to be marked accordingly.
Comment 8 WebKit Commit Bot 2018-10-01 12:40:56 PDT 
Comment on attachment 350954 [details]
Patch

Clearing flags on attachment: 350954

Committed r236684: <https://trac.webkit.org/changeset/236684>
Comment 9 WebKit Commit Bot 2018-10-01 12:40:58 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2018-10-01 12:41:38 PDT 
<rdar://problem/44917655>