RESOLVED FIXED 190010
Split NaN-check into separate test 
https://bugs.webkit.org/show_bug.cgi?id=190010
Summary Split NaN-check into separate test
Dominik Inführ
Reported 2018-09-26 14:01:34 PDT
Split NaN-check into separate test
Attachments
Patch (3.26 KB, patch)
2018-09-26 14:05 PDT, Dominik Inführ 		no flags
DetailsFormatted DiffDiff
Patch (3.23 KB, patch)
2018-09-27 02:21 PDT, Dominik Inführ 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews113 for mac-sierra (3.06 MB, application/zip)
2018-09-27 04:18 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dominik Inführ
Comment 1 2018-09-26 14:05:55 PDT
Created attachment 350900 [details] Patch
Saam Barati
Comment 2 2018-09-26 18:19:43 PDT
Comment on attachment 350900 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350900&action=review > JSTests/ChangeLog:9 > + DataView exposes NaN-representation, which is not necessarily the same on each > + architecture. Therefore move the check of the NaN-representation into its own > + file such that we can disable this test on MIPS where NaN-representation can be > + different on older CPUs. nit: Please move this underneath the "Reviewed by"
Dominik Inführ
Comment 3 2018-09-27 02:21:16 PDT
Created attachment 350954 [details] Patch
Dominik Inführ
Comment 4 2018-09-27 02:28:31 PDT
Thank you very much for the review! I've updated the ChangeLog.
EWS Watchlist
Comment 5 2018-09-27 04:18:42 PDT
Comment on attachment 350954 [details] Patch Attachment 350954 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9366830 New failing tests: storage/indexeddb/cursor-update.html
EWS Watchlist
Comment 6 2018-09-27 04:18:43 PDT
Created attachment 350955 [details] Archive of layout-test-results from ews113 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-sierra Platform: Mac OS X 10.12.6
Michael Catanzaro
Comment 7 2018-10-01 12:14:35 PDT
(In reply to Build Bot from comment #5) > Comment on attachment 350954 [details] > Patch > > Attachment 350954 [details] did not pass mac-debug-ews (mac): > Output: https://webkit-queues.webkit.org/results/9366830 > > New failing tests: > storage/indexeddb/cursor-update.html This test has been flaky for years. Really needs to be marked accordingly.
WebKit Commit Bot
Comment 8 2018-10-01 12:40:56 PDT
Comment on attachment 350954 [details] Patch Clearing flags on attachment: 350954 Committed r236684: <https://trac.webkit.org/changeset/236684>
WebKit Commit Bot
Comment 9 2018-10-01 12:40:58 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2018-10-01 12:41:38 PDT
<rdar://problem/44917655>
Note You need to log in before you can comment on or make changes to this bug.