Bug 189989 - MiniBrowser doesn't respect default enabled-ness of experimental and internal debug features
Summary: MiniBrowser doesn't respect default enabled-ness of experimental and internal...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-25 22:04 PDT by Ryosuke Niwa
Modified: 2018-09-26 12:48 PDT (History)
7 users (show)

See Also:


Attachments
Fixes the bug (2.27 KB, patch)
2018-09-25 22:06 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2018-09-25 22:04:20 PDT
All experimental and internal debug features are disabled by default in MiniBrowser.
We should match the default values of the features instead.
Comment 1 Ryosuke Niwa 2018-09-25 22:06:44 PDT
Created attachment 350846 [details]
Fixes the bug
Comment 2 Anders Carlsson 2018-09-26 07:03:49 PDT
Comment on attachment 350846 [details]
Fixes the bug

I think you can use objectForKey + boolValue on the returned object to avoid two lookups.
Comment 3 Ryosuke Niwa 2018-09-26 12:43:10 PDT
(In reply to Anders Carlsson from comment #2)
> Comment on attachment 350846 [details]
> Fixes the bug
> 
> I think you can use objectForKey + boolValue on the returned object to avoid
> two lookups.

Per IRC conversation, it looks like boolValue on NSString behaves differently from boolForValue on NSUserDefaults.

https://developer.apple.com/documentation/foundation/nsstring/1409420-boolvalue?language=objc

https://developer.apple.com/documentation/foundation/nsuserdefaults/1416388-boolforkey?language=objc

I'm gonna stick with boolForKey for now.
Comment 4 Ryosuke Niwa 2018-09-26 12:47:49 PDT
Comment on attachment 350846 [details]
Fixes the bug

Clearing flags on attachment: 350846

Committed r236518: <https://trac.webkit.org/changeset/236518>
Comment 5 Ryosuke Niwa 2018-09-26 12:47:52 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-09-26 12:48:26 PDT
<rdar://problem/44804642>