RESOLVED FIXED 189989
MiniBrowser doesn't respect default enabled-ness of experimental and internal debug features 
https://bugs.webkit.org/show_bug.cgi?id=189989
Summary MiniBrowser doesn't respect default enabled-ness of experimental and internal...
Ryosuke Niwa
Reported 2018-09-25 22:04:20 PDT
All experimental and internal debug features are disabled by default in MiniBrowser. We should match the default values of the features instead.
Attachments
Fixes the bug (2.27 KB, patch)
2018-09-25 22:06 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2018-09-25 22:06:44 PDT
Created attachment 350846 [details] Fixes the bug
Anders Carlsson
Comment 2 2018-09-26 07:03:49 PDT
Comment on attachment 350846 [details] Fixes the bug I think you can use objectForKey + boolValue on the returned object to avoid two lookups.
Ryosuke Niwa
Comment 3 2018-09-26 12:43:10 PDT
(In reply to Anders Carlsson from comment #2) > Comment on attachment 350846 [details] > Fixes the bug > > I think you can use objectForKey + boolValue on the returned object to avoid > two lookups. Per IRC conversation, it looks like boolValue on NSString behaves differently from boolForValue on NSUserDefaults. https://developer.apple.com/documentation/foundation/nsstring/1409420-boolvalue?language=objc https://developer.apple.com/documentation/foundation/nsuserdefaults/1416388-boolforkey?language=objc I'm gonna stick with boolForKey for now.
Ryosuke Niwa
Comment 4 2018-09-26 12:47:49 PDT
Comment on attachment 350846 [details] Fixes the bug Clearing flags on attachment: 350846 Committed r236518: <https://trac.webkit.org/changeset/236518>
Ryosuke Niwa
Comment 5 2018-09-26 12:47:52 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-09-26 12:48:26 PDT
<rdar://problem/44804642>
Note You need to log in before you can comment on or make changes to this bug.