RESOLVED FIXED 189984
Make frame flattening an internal debug feature 
https://bugs.webkit.org/show_bug.cgi?id=189984
Summary Make frame flattening an internal debug feature
Ryosuke Niwa
Reported 2018-09-25 19:18:26 PDT
Make frame flattening an internal debug feature
Attachments
Patch (7.27 KB, patch)
2018-09-25 19:19 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Fixed builds (7.36 KB, patch)
2018-09-25 19:52 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.39 KB, patch)
2018-09-25 21:22 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2018-09-25 19:19:55 PDT
Created attachment 350833 [details] Patch
EWS Watchlist
Comment 2 2018-09-25 19:22:42 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Ryosuke Niwa
Comment 3 2018-09-25 19:52:58 PDT
Created attachment 350838 [details] Fixed builds
Simon Fraser (smfr)
Comment 4 2018-09-25 20:40:30 PDT
Comment on attachment 350838 [details] Fixed builds View in context: https://bugs.webkit.org/attachment.cgi?id=350838&action=review > Source/WebKit/Shared/WebPreferences.yaml:894 > + humanReadableDescription: "Adjusts the height of iframes to its content" I think this should read "Enable frame flattening, which adjusts the height of an iframe to fit its contents"
Ryosuke Niwa
Comment 5 2018-09-25 21:20:38 PDT
(In reply to Simon Fraser (smfr) from comment #4) > Comment on attachment 350838 [details] > Fixed builds > > View in context: > https://bugs.webkit.org/attachment.cgi?id=350838&action=review > > > Source/WebKit/Shared/WebPreferences.yaml:894 > > + humanReadableDescription: "Adjusts the height of iframes to its content" > > I think this should read "Enable frame flattening, which adjusts the height > of an iframe to fit its contents" Fixed. Thanks for the review!
Ryosuke Niwa
Comment 6 2018-09-25 21:22:07 PDT
Created attachment 350844 [details] Patch for landing
Ryosuke Niwa
Comment 7 2018-09-25 21:23:14 PDT
Comment on attachment 350844 [details] Patch for landing Wait for GTK+/WPE EWS.
Ryosuke Niwa
Comment 8 2018-09-25 22:26:31 PDT
Comment on attachment 350844 [details] Patch for landing Clearing flags on attachment: 350844 Committed r236497: <https://trac.webkit.org/changeset/236497>
Ryosuke Niwa
Comment 9 2018-09-25 22:26:33 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2018-09-25 22:27:26 PDT
<rdar://problem/44785661>
Note You need to log in before you can comment on or make changes to this bug.