Bug 189979 - URLWithUserTypedString should return nil for URLs deemed to be invalid by WebCore::URL
Summary: URLWithUserTypedString should return nil for URLs deemed to be invalid by Web...
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-25 17:23 PDT by Alex Christensen
Modified: 2018-10-01 17:17 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.47 KB, patch)
2018-09-25 17:25 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.42 MB, application/zip)
2018-09-25 18:59 PDT, EWS Watchlist
no flags Details
Patch (5.57 KB, patch)
2018-09-26 17:27 PDT, Alex Christensen
youennf: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-sierra-wk2 (3.35 MB, application/zip)
2018-09-26 18:45 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-09-25 17:23:50 PDT
URLWithUserTypedString should return nil for URLs deemed to be invalid by WebCore::URL
Comment 1 Alex Christensen 2018-09-25 17:25:37 PDT
Created attachment 350817 [details]
Patch
Comment 2 Alex Christensen 2018-09-25 17:25:41 PDT
<rdar://problem/44119696>
Comment 3 EWS Watchlist 2018-09-25 18:59:32 PDT
Comment on attachment 350817 [details]
Patch

Attachment 350817 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9350966

New failing tests:
fast/frames/frame-limit.html
editing/selection/iframe.html
Comment 4 EWS Watchlist 2018-09-25 18:59:33 PDT
Created attachment 350830 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 5 Alex Christensen 2018-09-25 21:54:11 PDT
Test failures unrelated and fixed by https://trac.webkit.org/changeset/236492/webkit
Comment 6 Alex Christensen 2018-09-26 14:52:41 PDT
http://trac.webkit.org/r236524
Comment 7 Alex Christensen 2018-09-26 16:34:38 PDT
This broke these API tests:
    TestWebKitAPI.WebCore.URLExtras_Space
    TestWebKitAPI.WebCore.URLExtras_Solidus
    TestWebKitAPI.WebCore.URLExtras_NotSpoofed
    TestWebKitAPI.WKWebView.LoadAlternateHTMLStringFromProvisionalLoadErrorBackToBack
    TestWebKitAPI.WebKit.LoadInvalidURLRequest
Comment 8 Alex Christensen 2018-09-26 16:35:24 PDT
Reverted in r236533
Comment 9 Alex Christensen 2018-09-26 16:51:58 PDT
Reopening
Comment 10 Alex Christensen 2018-09-26 17:27:23 PDT
Created attachment 350930 [details]
Patch
Comment 11 EWS Watchlist 2018-09-26 18:45:16 PDT
Comment on attachment 350930 [details]
Patch

Attachment 350930 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9362950

New failing tests:
compositing/geometry/limit-layer-bounds-opacity-transition.html
Comment 12 EWS Watchlist 2018-09-26 18:45:18 PDT
Created attachment 350934 [details]
Archive of layout-test-results from ews105 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 13 Alex Christensen 2018-09-27 09:34:57 PDT
https://trac.webkit.org/changeset/236551/webkit
Comment 14 Alex Christensen 2018-10-01 17:17:17 PDT
Rolled out in http://trac.webkit.org/r236702