Functionality of storage process is moved to network process. The next step is to remove storage process code that does not function any more.
Created attachment 351106 [details] Patch
Comment on attachment 351106 [details] Patch Attachment 351106 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9385773 New failing tests: http/wpt/service-workers/persistent-importScripts.html
Created attachment 351120 [details] Archive of layout-test-results from ews105 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 351106 [details] Patch Attachment 351106 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9386012 New failing tests: http/wpt/service-workers/persistent-importScripts.html
Created attachment 351136 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Created attachment 351142 [details] Patch
Comment on attachment 351142 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351142&action=review Patch looks good. Please fix this EWS failure: In file included from /home/ews/gtk-wk2-ews/WebKit/WebKitBuild/Release/DerivedSources/WebKit/unified-sources/UnifiedSource24.cpp:1:0: ../../Source/WebKit/StorageProcess/glib/StorageProcessMainGLib.cpp:30:28: fatal error: StorageProcess.h: No such file or directory #include "StorageProcess.h" > Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py:102 > + time.sleep(5) Was this change intentional? If so, you should explain its rationale in the ChangeLog.
Comment on attachment 351142 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351142&action=review > Source/WebKit/WebKit.xcodeproj/project.pbxproj:4772 > 4188C157211378520012ABCD /* Storage-OSX-sandbox.entitlements */, Is this file still needed or can it be deleted and the reference removed from the project? What gives the networking process the entitlement previously given to the storage process, if it’s needed?
(In reply to mitz from comment #8) > Comment on attachment 351142 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=351142&action=review > > > Source/WebKit/WebKit.xcodeproj/project.pbxproj:4772 > > 4188C157211378520012ABCD /* Storage-OSX-sandbox.entitlements */, > > Is this file still needed or can it be deleted and the reference removed > from the project? > > What gives the networking process the entitlement previously given to the > storage process, if it’s needed? I am guessing the answer to the second question is that it’s not needed, because it’s for the sandbox cache, and the Networking process has its own cache with its own entitlement for it.
(In reply to Geoffrey Garen from comment #7) > Comment on attachment 351142 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=351142&action=review > > Patch looks good. > > Please fix this EWS failure: > > In file included from > /home/ews/gtk-wk2-ews/WebKit/WebKitBuild/Release/DerivedSources/WebKit/ > unified-sources/UnifiedSource24.cpp:1:0: > ../../Source/WebKit/StorageProcess/glib/StorageProcessMainGLib.cpp:30:28: > fatal error: StorageProcess.h: No such file or directory > #include "StorageProcess.h" > > > Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py:102 > > + time.sleep(5) > > Was this change intentional? If so, you should explain its rationale in the > ChangeLog. No. Just for some test and forgot to remove. Will fix.
(In reply to mitz from comment #9) > (In reply to mitz from comment #8) > > Comment on attachment 351142 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=351142&action=review > > > > > Source/WebKit/WebKit.xcodeproj/project.pbxproj:4772 > > > 4188C157211378520012ABCD /* Storage-OSX-sandbox.entitlements */, > > > > Is this file still needed or can it be deleted and the reference removed > > from the project? > > > > What gives the networking process the entitlement previously given to the > > storage process, if it’s needed? > > I am guessing the answer to the second question is that it’s not needed, > because it’s for the sandbox cache, and the Networking process has its own > cache with its own entitlement for it. Yes. The file should be removed from the project.
Created attachment 351252 [details] Patch
Comment on attachment 351252 [details] Patch r=me
Comment on attachment 351252 [details] Patch Clearing flags on attachment: 351252 Committed r236690: <https://trac.webkit.org/changeset/236690>
All reviewed patches have been landed. Closing bug.
<rdar://problem/44919627>