1. Visit <https://unixpapa.com/js/testkey.html> on iPad with a hardware keyboard attached. 2. Check the DOM 3 checkbox. 3. Press a special key, say F5, F6, Left Control, Left Option, Left Command, Left Shift, Caps Lock, Right Command, Right Option, Right Shift, Left Arrow, Up Arrow, Down Arrow, Right Arrow or Escape key (*). We either misidentify these keys as "Dead" or the name of UIKit-specific constant (e.g. UIKeyInputDownArrow). We should correctly identify a pressed key. (*) These are the special keys on the Magic Keyboard that are not system global (i.e. do not map to volume up, et cetera). Some keyboard may have additional special keys, including Page Up, Page Down, Num Lock/Clear, Home, End, and Forward Delete.
*** Bug 189436 has been marked as a duplicate of this bug. ***
Created attachment 350803 [details] Patch and layout tests
Created attachment 350804 [details] Patch and layout tests
Attachment 350804 [details] did not pass style-queue: ERROR: Source/WebCore/platform/ios/WebEvent.mm:147: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 350811 [details] Patch and layout tests
Attachment 350811 [details] did not pass style-queue: ERROR: Source/WebCore/platform/ios/WebEvent.mm:147: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 350812 [details] Patch and layout tests
Attachment 350812 [details] did not pass style-queue: ERROR: Source/WebCore/platform/ios/WebEvent.mm:147: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 350812 [details] Patch and layout tests Attachment 350812 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9350290 New failing tests: css3/viewport-percentage-lengths/vh-resize.html
Created attachment 350819 [details] Archive of layout-test-results from ews105 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 350812 [details] Patch and layout tests Attachment 350812 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9350520 New failing tests: fast/frames/lots-of-objects.html fast/frames/lots-of-iframes.html webarchive/adopt-attribute-styled-body-webarchive.html
Created attachment 350829 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
(In reply to Build Bot from comment #9) > Comment on attachment 350812 [details] > Patch and layout tests > > Attachment 350812 [details] did not pass mac-wk2-ews (mac-wk2): > Output: https://webkit-queues.webkit.org/results/9350290 > > New failing tests: > css3/viewport-percentage-lengths/vh-resize.html This failure is unrelated to this patch.
(In reply to Build Bot from comment #11) > Comment on attachment 350812 [details] > Patch and layout tests > > Attachment 350812 [details] did not pass ios-sim-ews (ios-simulator-wk2): > Output: https://webkit-queues.webkit.org/results/9350520 > > New failing tests: > fast/frames/lots-of-objects.html > fast/frames/lots-of-iframes.html > webarchive/adopt-attribute-styled-body-webarchive.html These failures are unrelated to this patch.
Created attachment 351087 [details] Patch and layout tests No change. Uploading the patch again to have the iOS EWS bots process it.
Attachment 351087 [details] did not pass style-queue: ERROR: Source/WebCore/platform/ios/WebEvent.mm:147: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 351087 [details] Patch and layout tests Clearing flags on attachment: 351087 Committed r236678: <https://trac.webkit.org/changeset/236678>
All reviewed patches have been landed. Closing bug.
<rdar://problem/44915471>
Committed attempt to fix the watchOS build in <https://trac.webkit.org/changeset/236694>. (Note that PLATFORM(IOS) := TARGET_OS_IPHONE and TARGET_OS_IPHONE is set when building for watchOS).