Bug 189972 – Allow for suffixes to com.apple.WebKit.WebContent

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Allow for suffixes to com.apple.WebKit.WebContent

[Alex Christensen]

Created attachment 350783 [details]
Patch

[Alex Christensen]

http://trac.webkit.org/r236474

[Radar WebKit Bug Importer]

<rdar://problem/44773386>

[Alexey Proskuryakov]

This will be tricky to start using, because many system frameworks hardcore existing WebContent names. We’ll need to work with them if we want to add more names.

[Darin Adler]

Comment on attachment 350783 [details]
Patch

Gets rid of the "com.apple.WebProcess" bundle ID. Was that being used anywhere?

[Alex Christensen]

(In reply to Alexey Proskuryakov from comment #4)
> This will be tricky to start using, because many system frameworks hardcode
> existing WebContent names. We’ll need to work with them if we want to add
> more names.

Tricky but possible.  I intend to do just that.

(In reply to Darin Adler from comment #5)
> Comment on attachment 350783 [details]
> Patch
> 
> Gets rid of the "com.apple.WebProcess" bundle ID. Was that being used
> anywhere?

I believe it's historical.

[Andy Estes]

Comment on attachment 350783 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350783&action=review

> Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm:89
> +    static bool mainBundleIsWebProcess = [[[NSBundle mainBundle] bundleIdentifier] hasPrefix:@"com.apple.WebKit.WebContent"];

I don’t know what suffixes you have in mind, but I’m a little surprised that the prefix string doesn’t end in a period. Will a suffix ever not be separated from the prefix by a period?

[Alex Christensen]

com.apple.WebKit.WebContent is valid
com.apple.WebKit.WebContent.something is valid
It can't have a period.  There might be no suffix.

[Andy Estes]

(In reply to Alex Christensen from comment #8)
> com.apple.WebKit.WebContent is valid
> com.apple.WebKit.WebContent.something is valid
> It can't have a period.  There might be no suffix.

com.apple.WebKit.WebContentdevelopment is also valid. Is that what you intend?

[Alex Christensen]

Are you suggesting we check for exact equality with "com.apple.WebKit.WebContent" or beginning with "com.apple.WebKit.WebContent."?  I think that's overkill, especially since the right solution is to remove these bundle checks entirely.

[Andy Estes]

(In reply to Alex Christensen from comment #10)
> Are you suggesting we check for exact equality with
> "com.apple.WebKit.WebContent" or beginning with
> "com.apple.WebKit.WebContent."?  I think that's overkill, especially since
> the right solution is to remove these bundle checks entirely

You could also check if the string begins with com.apple.WebKit.WebContent and is equal in length to the prefix or has a period as the first character in the suffix. That wouldn’t require two comparisons.