Bug 189949 – [JSC] offlineasm parser should handle CRLF in asm files

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Koby]

When working on Windows, LLInt's asm files might contain CRLFs, which currently fail the offlineasm parser.
This patch removes '\r's from the input file.

[Koby]

Created attachment 350752 [details]
Patch

[Mark Lam]

Comment on attachment 350752 [details]
Patch

r=me

[Mark Lam]

@Koby, in case you are new to WebKit development, since you don't have commit privileges yet, if you want a patch to be landed once a reviewer has granted a r+, you should set the cq flag to cq?.  That will tell the reviewer or other committers that you're done with the patch and that it's ready to land.

[Koby]

@Mark thanks, I am new and this is actually the first patch I'm trying to upload. To set the cq flag, should I use webkit-patch land-safely?

[Yusuke Suzuki]

(In reply to Koby from comment #4)
> @Mark thanks, I am new and this is actually the first patch I'm trying to
> upload. To set the cq flag, should I use webkit-patch land-safely?

You can set `cq?` flag for already uploaded patches in this web page.
Or passing `--request-commit` flag to `webkit-patch upload` when uploading the patch.

In this case, your patch is already marked as `r+`. So just setting `cq=?` to the uploaded patch works fine :)

[Koby]

Done :) The "Reviewed by NOBODY (OOPS!)." will updated automatically?

[WebKit Commit Bot]

Comment on attachment 350752 [details]
Patch

Clearing flags on attachment: 350752

Committed r236499: <https://trac.webkit.org/changeset/236499>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/44791913>

[Yusuke Suzuki]

(In reply to Koby from comment #6)
> Done :) The "Reviewed by NOBODY (OOPS!)." will updated automatically?

Yes!