Bug 189946 - Move Symbol API to SPI
Summary: Move Symbol API to SPI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-25 08:01 PDT by Keith Miller
Modified: 2018-09-26 13:05 PDT (History)
6 users (show)

See Also:


Attachments
Patch (19.52 KB, patch)
2018-09-25 08:03 PDT, Keith Miller
no flags Details | Formatted Diff | Diff
Patch (23.02 KB, patch)
2018-09-25 11:36 PDT, Keith Miller
no flags Details | Formatted Diff | Diff
Patch (23.31 KB, patch)
2018-09-25 12:05 PDT, Keith Miller
msaboff: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2018-09-25 08:01:44 PDT
Move Symbol API to SPI
Comment 1 Keith Miller 2018-09-25 08:03:10 PDT
Created attachment 350751 [details]
Patch
Comment 2 EWS Watchlist 2018-09-25 08:04:52 PDT
Attachment 350751 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:94:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:106:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:119:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:119:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:119:  The parameter name "attributes" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:131:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 6 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Keith Miller 2018-09-25 11:36:47 PDT
Created attachment 350771 [details]
Patch
Comment 4 EWS Watchlist 2018-09-25 11:48:03 PDT
Attachment 350771 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:94:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:106:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:119:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:119:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:119:  The parameter name "attributes" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:131:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:140:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 7 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Keith Miller 2018-09-25 12:05:58 PDT
Created attachment 350776 [details]
Patch
Comment 6 EWS Watchlist 2018-09-25 12:08:56 PDT
Attachment 350776 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:94:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:106:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:119:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:119:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:119:  The parameter name "attributes" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:131:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:140:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 7 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Michael Saboff 2018-09-26 12:55:28 PDT
Comment on attachment 350776 [details]
Patch

rs=me
Comment 8 Keith Miller 2018-09-26 13:04:33 PDT
Committed r236520: <https://trac.webkit.org/changeset/236520>
Comment 9 Radar WebKit Bug Importer 2018-09-26 13:05:22 PDT
<rdar://problem/44805073>