Bug 189937 - Don't cause a crash even when some IDL attribute is missing CEReactions
Summary: Don't cause a crash even when some IDL attribute is missing CEReactions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks: 154907
  Show dependency treegraph
 
Reported: 2018-09-24 17:06 PDT by Ryosuke Niwa
Modified: 2018-09-24 17:28 PDT (History)
9 users (show)

See Also:


Attachments
Don't release-assert even when CEReactions is missing (2.64 KB, patch)
2018-09-24 17:12 PDT, Ryosuke Niwa
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2018-09-24 17:06:27 PDT
It's not a good trade-off to cause a release assertion hit when there is an IDL attribute missing CEReactions.
Turn this into a debug-only assertion.
Comment 1 Ryosuke Niwa 2018-09-24 17:12:13 PDT
Created attachment 350715 [details]
Don't release-assert even when CEReactions is missing
Comment 2 Radar WebKit Bug Importer 2018-09-24 17:17:46 PDT
<rdar://problem/44746785>
Comment 3 Ryosuke Niwa 2018-09-24 17:28:44 PDT
Committed r236446: <https://trac.webkit.org/changeset/236446>